Allow loading offline sessions from loadCurrentSession #119

paulomarg · 2021-03-01T21:59:43Z

Currently, the loadCurrentSession method doesn't allow loading offline sessions from the request, which is desired for some apps.

Adding an optional parameter (defaulting to online) to allow returning offline sessions as well as online ones.

Type of change

Patch: Bug (non-breaking change which fixes an issue)
Minor: New feature (non-breaking change which adds functionality)
Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

I have added a changelog entry, prefixed by the type of change noted above
I have added/updated tests for this change
I have documented new APIs/updated the documentation for modified APIs (for public APIs)

docs/usage/oauth.md

src/auth/oauth/oauth.ts

src/utils/delete-current-session.ts

src/utils/load-current-session.ts

src/utils/test/load-current-session.test.ts

src/auth/oauth/oauth.ts

paulomarg requested a review from a team as a code owner March 1, 2021 21:59

paulomarg force-pushed the load_offline_sessions_from_requests branch from dfa1a37 to ac9c03c Compare March 1, 2021 22:01

mkevinosullivan reviewed Mar 1, 2021

View reviewed changes

Allow offline sessions in loadCurrentSession

4db4974

paulomarg force-pushed the load_offline_sessions_from_requests branch from a007bce to 4db4974 Compare March 2, 2021 14:19

mkevinosullivan approved these changes Mar 2, 2021

View reviewed changes

paulomarg merged commit e69a93d into main Mar 2, 2021

paulomarg deleted the load_offline_sessions_from_requests branch March 2, 2021 15:19

paulomarg temporarily deployed to production March 2, 2021 15:25 Inactive