Skip to content

Implement Variable width allocation for T_CLASS objects #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Implement Variable width allocation for T_CLASS objects #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c4b37bb
Introduce T_PAYLOAD to store object data on the eden heap
eightbitraptor Jan 21, 2021
1b469cb
Expose the variable width allocation API to other Ruby types
eightbitraptor Jan 21, 2021
f4d7888
Implement variable width allocation for T_CLASS/rb_classext_t
eightbitraptor Jan 21, 2021
3554067
Export T_PAYLOAD slots as part of ObjectSpace.dump_all
eightbitraptor Jan 21, 2021
59552d1
Check compilation with USE_RVARGC on Github Actions
eightbitraptor Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/compilers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ jobs:
# - { key: cppflags, name: USE_GC_MALLOC_OBJ_INFO_DETAILS, value: '-DUSE_GC_MALLOC_OBJ_INFO_DETAILS' }
- { key: cppflags, name: USE_LAZY_LOAD, value: '-DUSE_LAZY_LOAD' }
# - { key: cppflags, name: USE_RINCGC=0, value: '-DUSE_RINCGC=0' }
- { key: cppflags, name: USE_RVARGC=1, value: '-DUSE_RVARGC=1' }
# - { key: cppflags, name: USE_SYMBOL_GC=0, value: '-DUSE_SYMBOL_GC=0' }
# - { key: cppflags, name: USE_THREAD_CACHE=0, value: '-DUSE_THREAD_CACHE=0' }
# - { key: cppflags, name: USE_TRANSIENT_HEAP=0, value: '-DUSE_TRANSIENT_HEAP=0' }
Expand Down
5 changes: 5 additions & 0 deletions class.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,13 @@ rb_class_detach_module_subclasses(VALUE klass)
static VALUE
class_alloc(VALUE flags, VALUE klass)
{
#if USE_RVARGC
NEWOBJ_OF_SIZE(obj, struct RClass, klass, (flags & T_MASK) | FL_PROMOTED1 /* start from age == 2 */ | (RGENGC_WB_PROTECTED_CLASS ? FL_WB_PROTECTED : 0), sizeof(rb_classext_t));
obj->ptr = rb_payload_start_zero((VALUE)obj);
#else
NEWOBJ_OF(obj, struct RClass, klass, (flags & T_MASK) | FL_PROMOTED1 /* start from age == 2 */ | (RGENGC_WB_PROTECTED_CLASS ? FL_WB_PROTECTED : 0));
obj->ptr = ZALLOC(rb_classext_t);
#endif
/* ZALLOC
RCLASS_IV_TBL(obj) = 0;
RCLASS_CONST_TBL(obj) = 0;
Expand Down
10 changes: 10 additions & 0 deletions ext/objspace/objspace_dump.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,12 @@ dump_object(VALUE obj, struct dump_config *dc)
dump_append_ref(dc, obj);

dump_append(dc, ", \"type\":\"");
#if USE_RVARGC
if (rb_is_payload_object(obj)) {
dump_append(dc, "PAYLOAD\" }\n");
return;
}
#endif
dump_append(dc, obj_type(obj));
dump_append(dc, "\"");

Expand Down Expand Up @@ -636,7 +642,11 @@ objspace_dump_all(VALUE os, VALUE output, VALUE full, VALUE since)
}

/* dump all objects */
#if USE_RVARGC
rb_objspace_each_objects_with_payload(heap_i, &dc);
#else
rb_objspace_each_objects(heap_i, &dc);
#endif

return dump_result(&dc);
}
Expand Down
Loading