Use code units cache API #2704
Merged
Use code units cache API #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
|
I'm seeing indexing take 1m45s on core now, are you getting around the same? |
|
How are you measuring that? My benchmarks are showing an average of 29 seconds. |
vinistock
force-pushed
the
vs-use-code-units-cache
branch
from
20bf28e
to
50469d3
Compare
|
That was through VS Code, |
andyw8
approved these changes
Oct 10, 2024
vinistock
added
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2674, closes #2671
This PR adopts the new code units cache API from Prism, so that code unit locations can be computed faster.
Implementation
I recommend reviewing by commit. The new API allows us to instantiate a code units cache ahead of time, which is then passed to get the code units in a more performant way. In places where we previously passed the encoding, we now pass the cache.
Note: this actually fixed a bug in the locations for semantic highlighting.
Automated Tests
Existing tests cover it, but I fixed one of them which had an incorrect expectation.