Fix handle resolve multiple methods #1380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #1343
Implementation
When we invoke
resolve_method
, do not pick only the first match, bot return an array containing all matches.find
byselect
Handle in all requests using this resolve following advices:
Location
for definitionQuestion: On
signature_help
request, we could propose multiple signatures, with for each signature information the related documentation and parameters. I did a try, it changes the interface, to allow user changing signature with arrow. You can find an example from VS Code documentation here. Do you think it can be better or bring some unwanted complexity? Idk how it's handled by other IDE.Automated Tests
Added tests in all request and indexer, again, if missed some useful cases, just say it 馃憤
Manual Tests
Given this code:
For hover on
something
:For go to definition on
something
:For signature_help on
something
: