Track rest, keyword rest and post parameters #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Nov 29, 2023
Morriar
reviewed
Nov 30, 2023
vinistock
force-pushed
the
vs/track_rest_parameters
branch
2 times, most recently
from
dfa098a
to
af9a467
Compare
Merged
Morriar
reviewed
Nov 30, 2023
vinistock
force-pushed
the
vs/track_rest_parameters
branch
from
af9a467
to
1a8af41
Compare
Morriar
approved these changes
Dec 1, 2023
st0012
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Another step for #899
This PR starts tracking rest, keywords and post parameters. After this PR, all parameter types are handled.
Implementation
Started handling the
rest,keyword_restandpostspart of the parameters node. For clarity, the parameters are:def foo(*a); enddef foo(**a); enddef foo(*a, b); end-> thebis the post hereAutomated Tests
Added tests.