Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build npm package step #363

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Fix build npm package step #363

merged 2 commits into from
Apr 6, 2022

Conversation

wcandillon
Copy link
Contributor

@chrfalch based on the log at https://github.com/Shopify/react-native-skia/runs/5856006149?check_suite_focus=true it seems to be what is missing? or is it related to the .bin directory resolution?

@wcandillon wcandillon requested a review from chrfalch April 6, 2022 18:11
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wcandillon wcandillon merged commit d7f96e1 into main Apr 6, 2022
@wcandillon wcandillon deleted the wcandillon-patch-4 branch April 7, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants