Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Minor shader improvement #356

Merged
merged 9 commits into from
Apr 6, 2022
Merged

💄 Minor shader improvement #356

merged 9 commits into from
Apr 6, 2022

Conversation

wcandillon
Copy link
Contributor

@wcandillon wcandillon commented Apr 6, 2022

fixes #150
fixes #345

@wcandillon wcandillon self-assigned this Apr 6, 2022
@wcandillon wcandillon marked this pull request as draft April 6, 2022 06:49
@wcandillon wcandillon requested a review from chrfalch April 6, 2022 06:54
@wcandillon wcandillon marked this pull request as ready for review April 6, 2022 06:54
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcandillon
Copy link
Contributor Author

@schiller-manuel We could update UniformValue to type UniformValue = number | Vector | readonly number[]; but I would like to check your example first.

@wcandillon
Copy link
Contributor Author

@chrfalch I added a small fix for a regression we introduced with the new dependency manager: 2e0e74f this was nicely caught by @schiller-manuel

@wcandillon wcandillon merged commit 1a851ec into main Apr 6, 2022
@wcandillon wcandillon deleted the fix/uniform-array branch April 7, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants