Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify normalized coordinates in SKGL #342

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Clarify normalized coordinates in SKGL #342

merged 3 commits into from
Apr 4, 2022

Conversation

wcandillon
Copy link
Contributor

fixes #341

@wcandillon
Copy link
Contributor Author

@schiller-manuel does this help?

@wcandillon wcandillon self-assigned this Apr 4, 2022
@wcandillon wcandillon requested a review from chrfalch April 4, 2022 11:51
schiller-manuel
schiller-manuel reviewed Apr 4, 2022
View reviewed changes
Copy link
Contributor

@schiller-manuel schiller-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe then explicitly set canvas size to 256x256 instead of using flex:1?

@wcandillon
Copy link
Contributor Author

yes that's a good idea thks 🙌🏼

@wcandillon wcandillon merged commit 369f0bc into main Apr 4, 2022
@wcandillon wcandillon deleted the wcandillon-patch-3 branch April 7, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schiller-manuel schiller-manuel schiller-manuel left review comments

@chrfalch chrfalch chrfalch approved these changes

Assignees

@wcandillon wcandillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalizing coordinates in shaders
3 participants
@wcandillon @chrfalch @schiller-manuel