Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use move semantics #340

Merged
merged 1 commit into from
Apr 6, 2022
Merged

use move semantics #340

merged 1 commit into from
Apr 6, 2022

Conversation

schiller-manuel
Copy link
Contributor

No description provided.

@wcandillon wcandillon requested a review from chrfalch April 4, 2022 12:50
@chrfalch
Copy link
Contributor

chrfalch commented Apr 4, 2022

This is awesome, @schiller-manuel, thanks for going through all of this.

I have one question, however, and pardon my rusty C++ skills here - since parameters are mainly passed as const references - wouldn't this mean that there is no need for std::move in a lot of the places where they've been added in your PR?

Obviously there are some places where it is correct to use it - and we should definitely change those.

@schiller-manuel
Copy link
Contributor Author

I only used std::move when not passed by const ref, at least that was the plan :) If you find instances where args are passed by const ref and I added std::move, let me know.

Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants