Added fix to make sure the python command is valid #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On MacOS 12.3 Python2 was deprecated and removed. We now only have Python3 to use. When building with ninja the Skia build system is setup to use python a lot of places through shebangs like ` #!/usr/bin/env python`. This doesn't work anymore, and this PR has added a few fixes to avoid this issue on newer machines: - Updated call to git-sync-deps to use python3 - Added bash script mapping python -> python3 - Added this bash script to path - Added --script-executable argument to gn gen to make sure it uses python3 as its script interpreter.
wcandillon
approved these changes
Apr 1, 2022
|
awesome 🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacOS 12.3 Python2 was deprecated and removed. We now only have Python3 to use.
When building with ninja the Skia build system is setup to use python a lot of places through shebangs like
#!/usr/bin/env python.This doesn't work anymore, and this PR has added a few fixes to avoid this issue on newer machines:
Fixes #329