Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly set font color in example app #291

Merged
merged 1 commit into from
Mar 24, 2022
Merged

explicitly set font color in example app #291

merged 1 commit into from
Mar 24, 2022

Conversation

schiller-manuel
Copy link
Contributor

this fixes text not being visible on darkmode #290

@schiller-manuel
explicitly set font color in example app
29efbd1 
this fixes text not being visible on darkmode Shopify#290
chrfalch
chrfalch approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @schiller-manuel! :) :)

@chrfalch chrfalch merged commit 467d9ee into Shopify:main Mar 24, 2022
@chrfalch chrfalch mentioned this pull request Mar 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfalch chrfalch chrfalch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schiller-manuel @chrfalch