🐞 Fix Bad Access exception #275
Conversation
| @@ -0,0 +1,75 @@ | |||
| import { Canvas, useImage, Image } from "@shopify/react-native-skia"; | |||
There was a problem hiding this comment.
This is the perfect test case :))
|
The use case is perfect. In fact it reminded me why I couldn't reproduce the error the last time (I forgot that I was displaying images gotten from makeImageSnapshot). This clearly fixes the issue on both iOS and Android but on iOS it looks like I could reproduce the error once. The screenshot below seems to confirm that this was the right version of the code running. Regardless this is still a dramatic improvement. |
|
Nice find - I've pushed an update that fixes this - still seeing some crashes on Android that I want to figure out, |
|
If we have a drawing that takes 50ms, animating will result in all frames being displayed slowly. Maybe we should skip the frame instead? In the context of gestures, not dropping frames seems to be quite a big issue. If we have a looping animation that runs at 32ms and we let it run 5 seconds, starting a gesture will wait for all frames to be drawn before starting the gesture which could take many seconds. |
|
The drawing time in |
ghost
added
the
|
Added a new implementation of the OpenGL renderer for Android that looks very promising. No errors occurs when running the heavy examples, reload and hot refresh works as expected! |
…alidated objects.
This was previously checking for if the define was defined - now it tests for the define to be 1
Moved drawFrame from virtual method (which might crash) to a pointer to a drawFunction. The pointer is nulled out when the impl view is destructed.
…urce was not released.
Now checking on each render.
chrfalch
force-pushed
the
bugfix/243-BAD_ACCESS
branch
from
c52df9b to
1d2965a
Compare
|
This is huge, congrats 🎉 |
|
Great to see this has been fixed! Can't wait for the new release. Thanks! |
This fixes BAD_ACCESS and SIG_ABORTS on iOS/Android in Skia views being accessed by the render thread after they have been deleted.
The PR Fixes adds a few guards to ensure that we're not accessing objects after destruction. A test with 100 Skia Views being constantly created/recreated has been added and can be used to verify that this bug is fixed.
Fixes #243