✅ completion callback to spring and timing #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcandillon
changed the title
chrfalch
suggested changes
Mar 23, 2022
There was a problem hiding this comment.
I'm a bit unsure about renaming AnimationParams to TimingParams. I'm not sure if TimingParams are equal to AnimationParams :)
AnimationParams controls interpolation and control values (looping, yoyo) and has therefore no real connection to timing parameters which are duration and easing. I would believe that a spring or other custom animation could also benefit from using this type without it having to be related to timing.
Other than that I'm fine with the changes and addition of a callback to the animations!
chrfalch
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #239