Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👻 Inner Shadow #246

Merged
merged 13 commits into from
Mar 14, 2022
Merged

👻 Inner Shadow #246

merged 13 commits into from
Mar 14, 2022

Conversation

wcandillon
Copy link
Contributor

@wcandillon wcandillon commented Mar 12, 2022 •
edited
Loading

  • Make more examples which probably will reveal that we need a saveLayer step which will clarify the drop-shadow vs box-shadow semantic
  • Consolidate with CSS semantic (drop-shadow vs box-shadow)
  • Make inner a property
  • Document

@wcandillon wcandillon self-assigned this Mar 12, 2022
@wcandillon wcandillon requested a review from chrfalch March 13, 2022 15:20
@wcandillon wcandillon marked this pull request as ready for review March 13, 2022 15:20
chrfalch
chrfalch suggested changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

A few changes related to argument tests (isNull / isUndefined) that we might want to ensure is working when providing different optional parameters.

package/cpp/api/JsiSkImageFilterFactory.h Show resolved Hide resolved
@wcandillon wcandillon requested a review from chrfalch March 14, 2022 07:57
@wcandillon wcandillon merged commit e8532fb into main Mar 14, 2022
@wcandillon wcandillon deleted the feat/box-shadow branch March 14, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfalch chrfalch chrfalch approved these changes

Assignees

@wcandillon wcandillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcandillon @chrfalch