Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 FitBox #229

Merged
merged 4 commits into from
Mar 8, 2022
Merged

📦 FitBox #229

merged 4 commits into from
Mar 8, 2022

Conversation

wcandillon
Copy link
Contributor

The goal of the FitBox component is to automatically scale drawings, in a symmetric manner to the way images are scaled.
This has a couple of use-cases, one of them being the ability to automatically scale SVG exports.

@wcandillon wcandillon requested a review from chrfalch March 8, 2022 08:20
@wcandillon wcandillon self-assigned this Mar 8, 2022
@wcandillon wcandillon changed the title FitBox 📦 FitBox Mar 8, 2022
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super nice, found a typo and made a documentation suggestion

docs/docs/shapes/fitbox.md Outdated Show resolved Hide resolved
docs/docs/shapes/fitbox.md Outdated Show resolved Hide resolved
@wcandillon wcandillon requested a review from chrfalch March 8, 2022 11:56
@wcandillon
Copy link
Contributor Author

Implemented review comments 🙌🏼

@wcandillon wcandillon merged commit 51b2785 into main Mar 8, 2022
@wcandillon wcandillon deleted the feat/fitbox branch March 14, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants