Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐙 Substancial reconciller improvements #227

Merged
merged 53 commits into from
Mar 16, 2022
Merged

🐙 Substancial reconciller improvements #227

merged 53 commits into from
Mar 16, 2022

Conversation

wcandillon
Copy link
Contributor

@wcandillon wcandillon commented Mar 5, 2022 •
edited
Loading

The goal of this PR is to remove substantial bottlenecks in the reconciller.
This also fixes a bug where we were drawing everything twice on each frame.

  • Reanimated 2 support

@wcandillon wcandillon requested a review from chrfalch March 5, 2022 17:22
@wcandillon wcandillon changed the title Improve Node management Substancial Reconciller improvements Mar 7, 2022
@wcandillon wcandillon changed the title Substancial Reconciller improvements 🐙 Substancial Reconciller improvements Mar 7, 2022
@wcandillon wcandillon changed the title 🐙 Substancial Reconciller improvements 🐙 Substancial reconciller improvements Mar 8, 2022
@wcandillon wcandillon changed the base branch from feat/mask to main March 9, 2022 09:02
@wcandillon
Copy link
Contributor Author

wcandillon commented Mar 9, 2022 •
edited
Loading

@chrfalch Ready for review. I would like to re-purpose useSharedValueEffect to work with the new model and then give the useValueEffect effect to deal with any other animation provider. Let me know what you think. If we decide to not re-purpose it, we should remove it.

@wcandillon wcandillon mentioned this pull request Mar 13, 2022
Closed
chrfalch
chrfalch approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super awesome work!

@wcandillon wcandillon merged commit ddae5f8 into main Mar 16, 2022
@wcandillon wcandillon deleted the automatic-mask-clipping branch March 28, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfalch chrfalch chrfalch approved these changes

Assignees

@wcandillon wcandillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcandillon @chrfalch