Backdrop filters #196
Backdrop filters #196
Conversation
|
@chrfalch Ready to review. This PR also contains a small clean up of some of the "processors" (Colors, Paths, RRect, Clips). |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
I have a few comments about the I prefix on types (in relation to our discussion about the same in the animation PR). Should we avoid this all over?
Also some typos in the documentation, and I'd also like to add a description of what a backdrop is in the docs.
|
@chrfalch Ready for review 🙋🏼♂️ I'm still confused about the current state of the podfile lock but we will discuss it offline. |
example/src/Examples/Drawing/Context/functions/findClosestElementToPoint.ts
Show resolved
Hide resolved
| ({ canvas, paint }, { start, end, stroke, path: pathDef }) => { | ||
| const path = processPath(pathDef); | ||
| ({ canvas, paint }, { start, end, stroke, ...pathProps }) => { | ||
| const path = processPath(pathProps.path).copy(); |
There was a problem hiding this comment.
trim() is mutating the path.
There was a problem hiding this comment.
Not sure if I understand - if trim is used inside processPath, maybe processPath should be the one doing the copy operation?
There was a problem hiding this comment.
the trim is not used in processPath rather in this component (in the next step)
| export interface ImageFilterFactory { | ||
| MakeOffset(dx: number, dy: number, input: IImageFilter | null): IImageFilter; |
There was a problem hiding this comment.
Would it be correct to put documentation / comments on these methods here?
Add the possibility to create backdrop filters.
We're taking advantage of this new feature to clean up shape processing.