Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring the matrix3 API #186

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Minor refactoring the matrix3 API #186

merged 3 commits into from
Feb 10, 2022

Conversation

wcandillon
Copy link
Contributor

The goal of this PR is a slight improvement of the Matrix3 API:

  • No more need to invoke skiaMatrix3
  • Add support for supplying the matrix directly in the transform properties
  • Add direct constructor of the matrix via jsiskmatrix::fromValue

@wcandillon wcandillon requested a review from chrfalch February 8, 2022 05:26
@wcandillon wcandillon self-assigned this Feb 8, 2022
chrfalch
chrfalch approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this one! Had this exact need the other day!!

@wcandillon wcandillon merged commit 617d4a8 into main Feb 10, 2022
@wcandillon wcandillon deleted the fix/matrix branch February 28, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfalch chrfalch chrfalch approved these changes

Assignees

@wcandillon wcandillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcandillon @chrfalch