-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draw Glyphs #179
Draw Glyphs #179
Conversation
@@ -9,7 +9,7 @@ const { width, height } = Dimensions.get("window"); | |||
export const COLS = 8; | |||
export const ROWS = 15; | |||
export const SYMBOL = { width: width / COLS, height: height / ROWS }; | |||
const symbols = "abcdefghijklmnopqrstuvwxyz".split(""); | |||
const symbols = "abcdefghijklmnopqrstuvwxyz".toUpperCase().split(""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be amazing to have the entire Latin extended characters just for reference, what do you think?
Both lowercase and uppercase:
ĀāĂ㥹ĆćĈĉĊċČčĎďĐđĒēĔĕĖėĘęĚěĜĝĞğĠġĢģĤĥĦħĨĩĪīĬĭĮįİıIJijĴĵĶķĸĹĺĻļĽľĿŀŁłŃńŅņŇňŊŋŌōŎŏŐőŒœŔŕŖŗŘřŚśŜŝŞşŠšŢţŤťŦŧŨũŪūŬŭŮůŰűŲųŴŵŶŷŸŹźŻżŽž
Only lowercase:
āăąćĉċčďđēĕėęěĝğġģĥħĩīĭįi̇ıijĵķĸĺļľŀłńņňŋōŏőœŕŗřśŝşšţťŧũūŭůűųŵŷÿźżž
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed this needs to be tested. In this particular example, we use a custom font that only supports these codepoints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! It's happening!!! 🎉 🎉
I think the API looks correct but the examples use codepoints
instead of GlyphIds
. I left a few comments where I saw that being used - let me know if that doesn't make sense!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I personally likely won't use getGlyphIds
because we already have functions for that when we do our text shaping calculations but I can see how it's useful in these examples 👍 Thanks for updating all of this to use glyphIds instead of codepoints! 🎉 I just noticed one small typo in the example here:
docs/docs/text/text.md
Outdated
@@ -29,34 +28,10 @@ export const HelloWorld = () => { | |||
y={0} | |||
value="Hello World" | |||
familyName="serif" | |||
size={32} | |||
text={32} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to update value
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes thanks 🙌🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
cc @christikaes
Font
toIFont
for consistency<Text value="
to<Text text="
for consistency