Add some trouble shootings for android installation #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to run |
|
@pistonsky is that something related to my PR? |
rvasseur31
reviewed
Jan 27, 2022
README.md
Outdated
| For error **_CMake 'X.X.X' was not found in SDK, PATH, or by cmake.dir property._** | ||
|
|
||
| open _Tools > SDK Manager_, switch to the _SDK Tools_ tab. | ||
| Find `CMake`and click _Show Package Details_ and download compatiable version **'X.X.X'**, and apply to install. |
There was a problem hiding this comment.
You forgot a space after CMake
README.md
Outdated
| @@ -44,6 +44,16 @@ If the NDK is not installed, you can install it via Android Studio by going to t | |||
|
|
|||
| And then the _SDK Location_ section. It will show you the NDK path, or the option to Download it if you don't have it installed. | |||
|
|
|||
| And them the _Modules_ section. click on `shopify_react-native-skia` and select _NDK version_ with dropdown, and click on apply | |||
This is probably not related to this PR, I saw and commented on the issue you filed about this. I don't think you should need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure i am the only one who got in this error, but found it will be helpful for others to configure there settings.