Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace all <angled> user header imports with correct "quotes" syntax #1113

Merged
merged 3 commits into from
Nov 27, 2022

Conversation

mrousavy
Copy link
Contributor

@mrousavy mrousavy commented Nov 18, 2022

…"` syntax

Otherwise this makes the build fail if imported in VisionCamera - see slack

#(import|include) <(Sk[a-zA-Z0-9.]*)>

with

#$1 "$2"

…"` syntax

Otherwise this makes the build fail if imported in VisionCamera - see slack
@mrousavy mrousavy changed the title fix: Replace all <angled> user header imports with correct `"quotes… fix: Replace all <angled> user header imports with correct "quotes" syntax Nov 18, 2022
@chrfalch
Copy link
Contributor

Hi, @mrousavy! Thanks for the PR - I've updated it to the latest (after the native dom) and there are probably some includes missing, would it be possible to run the script (I know you created one!) once again, and then I'll test this change on both Android and iOS before we merge.

@mrousavy
Copy link
Contributor Author

Cool - yep re-ran it, no files changed! 👍

Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks @mrousavy

@chrfalch chrfalch merged commit 9aa784d into Shopify:main Nov 27, 2022
@mrousavy
Copy link
Contributor Author

mrousavy commented May 2, 2023

sed -i "" -r "s/#(import|include) <((RNSk|JsiSk|Sk)[a-zA-Z0-9.]*)>/#\1 \"\2\"/g" ./**/*.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants