feat: allow using multiple performance profilers

[ElviraBurchik]

Motivation

The motivation behind this change is to allow using the library in brownfield apps with multiple entry points Native <-> React Native.

Description

Currently if multiple PerformanceProfiler instances are used in an app, they will “mix” render completion events. Because useNativeRenderCompletionEvents listens only RENDER_COMPLETION_EVENT_NAME and does not differentiate between 2 contexts running at the same time. That results in ScreenProfilerNotStartedError when a screen is pushed in the other context.

This PR changes the way native onRenderCompleted event gets reported.
Before PerformanceProfiler would listen to all RENDER_COMPLETION_EVENT_NAME events reported by native views and pass them to StateController. Now listening to onRenderCompleted event is moved down to PerformanceMeasureView.tsx level and became an instance-level event, instead of global one. Now when events don't go up to PerformanceProfiler, they don't get mixed up when we have multiple Profilers running.

Packages affected:

• react-native-performance

Test plan

It's not easy to reproduce the issue in fixture app. I suggest to first run fixture and confirm that nothing is broken, and after that test the fix in Shopify Mobile.

Testing in the fixture app:

1. Do rm -rf fixture/dist && yarn up && yarn ios/android to run a clean build with the fix
2. Go to Nested Context Screen - you are already inside the nested ProfilerContext and should see no errors in logs
3. Press the button to open a new screen inside the nested ProfilerContext - again, you should see no errors in logs

testing-nested-profiler.mov

Tips:

• Try on both iOS and Android
• Try to open other screens before navigating to Nested Context Screen, or after.
• Try to change the LogLevel for the main ProfilerContext to LogLevel.Error, but set a lower level (Debug) for the nested profiler in NestedContextScreen: <PerformanceProfiler logLevel={LogLevel.Debug}>. You should see no performance logs before entering nested context, and start getting them once opening Nested Context Screen

Checklist

• I have added a decision record entry, PR includes changes to monorepo setup that may require explanation

[frankfka]

Code changes re: rendering callbacks make sense to me - have not 🎩 but i'd love to do this locally - what are the steps?

[fortmarek]

🎩 'd and works well 👍

[fortmarek]

Maybe we should at least keep LogLevel.Warn?

[ElviraBurchik]

Yes, absolutely, I used it for testing and forgot to remove 👍

[frankfka]

I was able to test this on Shopify Mobile for Android & iOS - this change fixed the reported issue :)