This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Use absolute import path when importing apollo-codegen legacyIR #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
Ah fun snapit seems bust. #2821 seems like it might fix, though it's weird that type-check passes locally |
Fixes import error when using the mjs version of the graphql-tool-utilities package with node
BPScott
force-pushed
the
fixcodegenimport
branch
from
0d070ba
to
2879992
Compare
|
/snapit |
|
🫰✨ Thanks @BPScott! Your snapshots have been published to npm. Test the snapshots by updating your "graphql-fixtures": "0.0.0-snapshot-20240828012157",
"graphql-tool-utilities": "0.0.0-snapshot-20240828012157",
"graphql-typescript-definitions": "0.0.0-snapshot-20240828012157",
"graphql-validate-fixtures": "0.0.0-snapshot-20240828012157",
"@shopify/react-i18n": "0.0.0-snapshot-20240828012157",
"@shopify/react-i18n-universal-provider": "0.0.0-snapshot-20240828012157" |
|
Tested this locally in |
alex-page
approved these changes
Aug 28, 2024
GoodForOneFare
approved these changes
Aug 28, 2024
emiryy
approved these changes
Aug 28, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes import error when using the mjs version of the graphql-tool-utilities package with node
Grumble
The graphql packages should probably have always been commonjs only, but it's about 4 years too late for that.