This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Add export types to fix typescript moduleResolution:"node16" compatability #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds typescript support when consumers are using `moduleResolution:"node16"` in their tsconfig file. The `types` and `typesVersions` field are still needed for consumers that still use `moduleResolution:"node"`
BPScott
changed the title
heathernfran
approved these changes
Aug 24, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2386.
Add
typesfields in exports maps.This adds typescript support when consumers are using
moduleResolution:"node16"in their tsconfig file.The
typesandtypesVersionsfield are still needed for consumers that still usemoduleResolution:"node".Along the way:
typesandtypesVersionskeys.