This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Bump required node version to >=12.14.0 and build using rollup #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atesgoral
reviewed
May 20, 2021
|
LGTM. Good luck with CI! |
BPScott
force-pushed
the
node-and-skn
branch
6 times, most recently
from
749e2ba
to
705ae44
Compare
BPScott
changed the title
atesgoral
reviewed
May 21, 2021
atesgoral
reviewed
May 21, 2021
atesgoral
reviewed
May 21, 2021
dahukish
reviewed
May 21, 2021
.github/workflows/node-ci.yml
Outdated
| @@ -32,167 +32,33 @@ jobs: | |||
| name: Restore yarn cache | |||
| with: | |||
| path: ${{ steps.yarn-cache-get-dir.outputs.dir }} | |||
| key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | |||
| key: ${{ runner.os }}-node${{ matrix.node-version }}-yarn-${{ hashFiles('**/yarn.lock') }} | |||
The polyfills it provides are not needed in node 12
- use consistent yarn version - always use `vNUMBER` syntax - always define node version, then yarn
|
Alrighty then. Major release time. Let's do this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A pair of breaking changes.
This PR also contains some CI simplifications copied from #1908. Hopefully that can get merged then I'll rebase this PR.
Type of change
Every package: MAJOR