This repository was archived by the owner on Jan 10, 2025. It is now read-only.
Faster unit test CI job #1201
Merged
Faster unit test CI job #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoodForOneFare
commented
Dec 2, 2019
| @@ -7,8 +7,10 @@ | |||
| "build": "yarn tsc --build packages", | |||
| "lint": "eslint '**/*.{ts,tsx}'", | |||
| "ci:lint-docs": "yarn generate docs && test -z \"$(git status --porcelain)\" || echo 'The root README has not been updated. Run `yarn generate docs` in the root of your quilt directory and try again.'", | |||
| "pretest": "yarn run build", | |||
| "test": "NODE_ICU_DATA=node_modules/full-icu jest --maxWorkers=3 --coverage=false", | |||
| "_test": "NODE_ICU_DATA=node_modules/full-icu jest", | |||
|
For what it's worth, we switched from Jest to Zora and our tests (just 35K lines of Typescript) went from 30 seconds to 2 seconds. It is very fast and we love it. |
|
Thanks for the tip, @newtack! Zora looks really interesting, and it's always great to learn about a new contender 😄 In case anyone else stumbles across this PR, I'd like to make it clear that Jest is not a bottleneck in Shopify's CI. The low-hanging fruit here is TypeScript compilation. To that end, we've been experimenting with improving TypeScript's caching performance in CI, and could probably just do a build with type checking disabled to really speed things up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Speed up CI's unit test job a bit. Right now, it's the bottleneck on shipping, and very slow to give feedback about failing tests:
This is because a
pretestbuild step was added. This makes sense for local test runs where e2e tests are part of the flow. However, CI's unit test job excludes tests that need build artefacts, so there's no need to build.Is it fast, tho?
Faster.
Getting the build step faster is probably going to require Node 12 + TypeScript support for threaded builds.
Type of change
CI / infrastructure.
Checklist
I have added a changelog entry, prefixed by the type of change noted above