fix export 🐛 #1187

michenly · 2019-11-20T20:45:06Z

Description

Patch: Bug/ Documentation fix (non-breaking change which fixes an issue or adds documentation)
Minor: New feature (non-breaking change which adds functionality)
Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

sambostock

This fixes the default export, but should we also continue exporting it by name, in case anyone has started depending on the named export?

michenly · 2019-11-20T20:50:51Z

the name export wasn't actually working in the last version so I am not worry 😹 (ie import {metrics} from '@shopify/koa-metrics' doesnt work)

michenly force-pushed the fix-koa-metric-export branch from a01d747 to 8488807 Compare November 20, 2019 20:46

michenly assigned michenly and ismail-syed Nov 20, 2019

michenly requested review from sambostock and marutypes November 20, 2019 20:47

michenly unassigned ismail-syed Nov 20, 2019

michenly requested a review from ismail-syed November 20, 2019 20:47

marutypes approved these changes Nov 20, 2019

View reviewed changes

sambostock approved these changes Nov 20, 2019

View reviewed changes

michenly force-pushed the fix-koa-metric-export branch from 8488807 to e1a612d Compare November 20, 2019 20:57

ismail-syed approved these changes Nov 20, 2019

View reviewed changes

fix export 🐛

c6de407

michenly force-pushed the fix-koa-metric-export branch from e1a612d to c6de407 Compare November 20, 2019 21:25

michenly merged commit 4ac87e5 into master Nov 20, 2019

michenly deleted the fix-koa-metric-export branch November 20, 2019 23:06

michenly temporarily deployed to production November 21, 2019 17:49 Inactive

michenly temporarily deployed to michenly-beta November 21, 2019 17:54 Inactive

theodoretan temporarily deployed to gem December 10, 2019 21:19 Inactive