Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated v10 custom properties from stylelint-polaris #9887

Merged
merged 10 commits into from
Aug 15, 2023
Merged

Remove deprecated v10 custom properties from stylelint-polaris #9887

merged 10 commits into from
Aug 15, 2023

Conversation

lgriffee
Copy link
Member

@lgriffee lgriffee commented Aug 3, 2023

WHY are these changes introduced?

Fixes #8420

WHAT is this pull request doing?

Removes these deprecated v10 custom properties from stylelint-polaris which were added in #8549 and #9074.

@lgriffee lgriffee self-assigned this Aug 3, 2023
sam-b-rose
sam-b-rose approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for following up on this work @lgriffee 💯

chloerice
chloerice approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@chloerice chloerice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

lgriffee
lgriffee commented Aug 7, 2023
View reviewed changes
stylelint-polaris/index.js
Comment on lines -59 to -60
'--p-override-transparent',
'--p-badge-mix-blend-mode',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

'--p-override-transparent',
'--p-badge-mix-blend-mode',

While these two tokens are not deprecated v10 custom properties they can be removed since they are no longer present in polaris or web (see audit here).

@lgriffee
Copy link
Member Author

lgriffee commented Aug 7, 2023 •
edited
Loading

While running through the token regex's in our v10 to v11 migration guide to confirm that none of these tokens are left in polaris or web I came across 3 tokens that still exist in web.

  • --p-border-radius-wide
  • --p-icon
  • --p-shadow-transparent

In an effort to try and remove all custom-property-disallowed-list rules in the same major version I'm going to try and remove them in web before shipping this PR (so we don't ship back to back major versions). I've left the tokens for now in the PR until they are officially removed in web.

@lgriffee
Copy link
Member Author

lgriffee commented Aug 15, 2023 •
edited
Loading

I've confirmed that all tokens being removed in this PR have been removed in web (and polaris).

Originally, I had also slated to remove the styelint-polaris documentation pages on polaris.shopify.com but realized that the editor links will 404 if folks are on an older version of stylelint-polaris. We will need to develop a strategy for sunsetting legacy stylelint-polaris rule pages.

@lgriffee lgriffee merged commit a3da87e into main Aug 15, 2023
8 checks passed
@lgriffee lgriffee deleted the stylelint-remove-v10-legacy branch August 15, 2023 19:10
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Aug 15, 2023
Merged
sam-b-rose pushed a commit that referenced this pull request Aug 15, 2023
@shopify-github-actions-access @github-actions
Version Packages (#9880)
a36581b 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/[email protected]

### Major Changes

- [#9887](#9887)
[`a3da87e2e`](a3da87e)
Thanks [@lgriffee](https://github.com/lgriffee)! - Removed deprecated
v10 custom properties from stylelint-polaris disallowed lists

### Patch Changes

- Updated dependencies
\[[`36e4ee8af`](36e4ee8)]:
    -   @shopify/[email protected]

## @shopify/[email protected]

### Minor Changes

- [#10042](#10042)
[`1d82a3b12`](1d82a3b)
Thanks [@m4thieulavoie](https://github.com/m4thieulavoie)! - introduce a
subdued prop to the popover pane component


- [#9868](#9868)
[`cb1dbbbd3`](cb1dbbb)
Thanks [@mattkubej](https://github.com/mattkubej)! - Introduce
disableKeyboardShortcuts prop to IndexFilters


- [#9862](#9862)
[`93b902094`](93b9020)
Thanks [@brittcorry](https://github.com/brittcorry)! - Added support for
the ```Filters``closeOnChildOverlayClick``` prop to `IndexFilters`


- [#9872](#9872)
[`f585a57e0`](f585a57)
Thanks [@fatimasajadi](https://github.com/fatimasajadi)! - Add a
critical status to the IndexTable

### Patch Changes

- [#10012](#10012)
[`3ae94cef0`](3ae94ce)
Thanks [@melvinadu](https://github.com/melvinadu)! - Fixed wrapping
overflow of strings with no spacing within `Filters` popover


- [#9889](#9889)
[`0cbdbb4f5`](0cbdbb4)
Thanks [@chloerice](https://github.com/chloerice)! - Set the preferred
position of `Pagination` and `Page` `secondaryActions` button tooltips
to `below`


- [#10045](#10045)
[`65ad4e27c`](65ad4e2)
Thanks [@sophschneider](https://github.com/sophschneider)! - Fixed
BannerExperimental no title hidden icon variant


- [#9885](#9885)
[`f0d288099`](f0d2880)
Thanks [@bsharrow](https://github.com/bsharrow)! - `Aligned
the`SkeletonPage\``title`font-weight with the`Page` title


- [#9860](#9860)
[`af0c9d4a2`](af0c9d4)
Thanks [@sophschneider](https://github.com/sophschneider)! - Updated CI
tests to account for both polarisSummerEditions2023 beta flag states


- [#9874](#9874)
[`5569ac69a`](5569ac6)
Thanks [@chloerice](https://github.com/chloerice)! - Fixed `Page` first
`Header` row misalignment


- [#9850](#9850)
[`57d8d5506`](57d8d55)
Thanks [@kyledurand](https://github.com/kyledurand)! - Rebuilt `Filters`
`SearchField`


- [#8988](#8988)
[`535b3fc91`](535b3fc)
Thanks [@m4thieulavoie](https://github.com/m4thieulavoie)! - Added
support for rendering `Text` `as` a `strong` tag


- [#9912](#9912)
[`00b831292`](00b8312)
Thanks [@samrose3](https://github.com/samrose3)! - Fixed primary Button
styles for Chrome on Android devices

- Updated dependencies
\[[`d1bee0f87`](d1bee0f),
[`36e4ee8af`](36e4ee8)]:
    -   @shopify/[email protected]
    -   @shopify/[email protected]

## @shopify/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @shopify/[email protected]

## @shopify/[email protected]

### Patch Changes

- Updated dependencies
\[[`a3da87e2e`](a3da87e),
[`36e4ee8af`](36e4ee8)]:
    -   @shopify/[email protected]
    -   @shopify/[email protected]

## @shopify/[email protected]

### Patch Changes

- [#9879](#9879)
[`d1bee0f87`](d1bee0f)
Thanks [@kyledurand](https://github.com/kyledurand)! - Optimized some
unoptimized icons

## @shopify/[email protected]

### Patch Changes

- Updated dependencies
\[[`a3da87e2e`](a3da87e),
[`36e4ee8af`](36e4ee8)]:
    -   @shopify/[email protected]
    -   @shopify/[email protected]

## @shopify/[email protected]

### Patch Changes

- [#9904](#9904)
[`36e4ee8af`](36e4ee8)
Thanks [@benwolfram](https://github.com/benwolfram)! - Added a unit to
the `space-0` token

## [email protected]

### Minor Changes

- [#9886](#9886)
[`d85099c89`](d85099c)
Thanks [@lgriffee](https://github.com/lgriffee)! - Updated Polaris
Stylelint version matchups chart

### Patch Changes

- Updated dependencies
\[[`d1bee0f87`](d1bee0f),
[`1d82a3b12`](1d82a3b),
[`36e4ee8af`](36e4ee8),
[`cb1dbbbd3`](cb1dbbb),
[`3ae94cef0`](3ae94ce),
[`0cbdbb4f5`](0cbdbb4),
[`93b902094`](93b9020),
[`65ad4e27c`](65ad4e2),
[`f0d288099`](f0d2880),
[`af0c9d4a2`](af0c9d4),
[`5569ac69a`](5569ac6),
[`f585a57e0`](f585a57),
[`57d8d5506`](57d8d55),
[`535b3fc91`](535b3fc),
[`00b831292`](00b8312)]:
    -   @shopify/[email protected]
    -   @shopify/[email protected]
    -   @shopify/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sam-b-rose added a commit that referenced this pull request Aug 15, 2023
@sam-b-rose
Merge branch 'main' into 11-12-0
1dc47d8 
* main:
  Version Packages (#9880)
  Remove deprecated v10 custom properties from `stylelint-polaris` (#9887)
sam-b-rose added a commit that referenced this pull request Aug 15, 2023
@sam-b-rose
Merge remote-tracking branch 'origin/main' into 11-12-0
06ae11e 
* origin/main:
  Version Packages (#9880)
  Remove deprecated v10 custom properties from `stylelint-polaris` (#9887)
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@lgriffee
Remove deprecated v10 custom properties from stylelint-polaris (Sho…
eb73c2f 
…pify#9887)

### WHY are these changes introduced?

Fixes Shopify#8420

### WHAT is this pull request doing?

Removes [these deprecated v10 custom
properties](Shopify#8405) from
`stylelint-polaris` which were added in
Shopify#8549 and
Shopify#9074.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-b-rose sam-b-rose sam-b-rose approved these changes

@chloerice chloerice chloerice approved these changes

@aaronccasanova aaronccasanova Awaiting requested review from aaronccasanova

Assignees

@lgriffee lgriffee

Labels
🤖Skip Major Check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After v11 ships remove deprecated v10 custom properties from stylelint-polaris
4 participants
@lgriffee @sam-b-rose @chloerice @aaronccasanova