Remove deprecated v8 custom properties, functions, mixins, and mixin maps from `stylelint-polaris` #8455

lgriffee · 2023-02-22T17:12:42Z

WHY are these changes introduced?

🚨 Before this PR ships we need to remove the same values from the _legacy-polaris-v8 file if they exist. 🚨

https://github.com/Shopify/web/pull/84457

WHAT is this pull request doing?

Removes deprecated v8 custom properties, functions, mixins, and maps from stylelint-polaris that do not exist in web (see the linked issue above for a list of these values).

lgriffee · 2023-02-22T17:13:19Z

polaris.shopify.com/pages/tools/stylelint-polaris/rules/[rule].tsx

@@ -33,7 +33,7 @@ const resourceLinks = {
  typography:
    'the [text component](/components/typography/text) or [font tokens](/tokens/font)',
  shape: 'Polaris [shape tokens](/tokens/shape)',
-  spacing: 'Polaris [spacking tokens](/tokens/spacing)',
+  spacing: 'Polaris [spacing tokens](/tokens/spacing)',


Caught a minor typo while removing these values

lgriffee · 2023-02-22T17:15:33Z

stylelint-polaris/index.js

-        /--p-button-font/,
-        /--p-badge-font/,


I think these were supposed to be --p-button-font-weight and --p-badge-font-weight. Just to be safe I did check web for --p-button-font and --p-badge-font and there are no instances of those values either.

.changeset/nice-panthers-doubt.md

…int-remove-v9-legacy

lgriffee · 2023-04-12T17:53:33Z

/snapit

github-actions · 2023-04-12T17:57:53Z

🫰✨ Thanks @lgriffee! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]

yarn add @shopify/[email protected]

yarn add @shopify/[email protected]

yarn add @shopify/[email protected]

yarn add @shopify/[email protected]

yarn add @shopify/[email protected]

Co-Authored-By: Aaron Casanova <[email protected]>

.changeset/nice-panthers-doubt.md

@skparkk

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Major Changes - [#8919](#8919) [`7349d4108`](7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ### Minor Changes - [#8924](#8924) [`4880e3ed7`](4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon - [#8861](#8861) [`2bc90503d`](2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor ## @shopify/[email protected] ### Major Changes - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8455](#8455) [`80eb3ac55`](80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris ### Minor Changes - [#8968](#8968) [`dbe68efb4`](dbe68ef) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `custom-property-disallowed-list` rule ## @shopify/[email protected] ### Minor Changes - [#8936](#8936) [`a2c9b1d24`](a2c9b1d) Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to HorizontalStack - [#8773](#8773) [`e8c5a2243`](e8c5a22) Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an optional `onSpinnerChange` prop to`TextField` - Added an optional `largeStep` prop to `TextField` - Added `TextField` `Spinner` keypress interactions for Home, End, Page Up, Page Down - [#8876](#8876) [`090d09683`](090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8937](#8937) [`fcc543928`](fcc5439) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns` to `HorizontalGrid` - [#8938](#8938) [`289dce569`](289dce5) Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation from `Grid` component - [#8935](#8935) [`7f3053342`](7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [#8596](#8596) [`421bb49dc`](421bb49) Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix minimum height overflowing in iOS Webkit browsers - [#8953](#8953) [`500eed660`](500eed6) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added `customActivator` prop to `TopBar.UserMenu` - Added support for setting a `ReactNode` on `ActionList` `Section` `title` ### Patch Changes - [#8842](#8842) [`bd64fa583`](bd64fa5) Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the Exiting animation state from Popovers, causing them to close immediately instead of after a 100ms delay. - [#8913](#8913) [`261355f07`](261355f) Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical alignment of elements within the `AlphaFilters` component - [#8954](#8954) [`f9366c22d`](f9366c2) Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property names to align with new component names for `HorizontalGrid`, `HorizontalStack`, and `VerticalStack` - [#8912](#8912) [`1cc47495a`](1cc4749) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions` to include wrapping tooltip on Popover activator - Updated dependencies \[[`4880e3ed7`](4880e3e), [`7349d4108`](7349d41), [`2bc90503d`](2bc9050)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`f1a3ad756`](f1a3ad7), [`80eb3ac55`](80eb3ac), [`dbe68efb4`](dbe68ef)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`f1a3ad756`](f1a3ad7), [`80eb3ac55`](80eb3ac), [`dbe68efb4`](dbe68ef)]: - @shopify/[email protected] ## [email protected] ### Minor Changes - [#8876](#8876) [`090d09683`](090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [#8973](#8973) [`f1a3ad756`](f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [#8967](#8967) [`45d978e7b`](45d978e) Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version matchup table to `stylelint-polaris` documentation - [#8986](#8986) [`f70f586ee`](f70f586) Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for the `react-rename-component` codemod - [#8935](#8935) [`7f3053342`](7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [#8920](#8920) [`2bad4e305`](2bad4e3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button to markdown headings with ids ### Patch Changes - [#8915](#8915) [`c8a130caf`](c8a130c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added scroll-margin-top to anchor links to prevent top bar overlay - [#8455](#8455) [`80eb3ac55`](80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris - Updated dependencies \[[`a2c9b1d24`](a2c9b1d), [`e8c5a2243`](e8c5a22), [`090d09683`](090d096), [`bd64fa583`](bd64fa5), [`f1a3ad756`](f1a3ad7), [`261355f07`](261355f), [`fcc543928`](fcc5439), [`4880e3ed7`](4880e3e), [`7349d4108`](7349d41), [`2bc90503d`](2bc9050), [`f9366c22d`](f9366c2), [`289dce569`](289dce5), [`7f3053342`](7f30533), [`421bb49dc`](421bb49), [`500eed660`](500eed6), [`1cc47495a`](1cc4749)]: - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…maps from `stylelint-polaris` (Shopify#8455) ### WHY are these changes introduced? Fixes Shopify#7622 <hr> 🚨 **Before this PR ships we need to remove the same values from the `_legacy-polaris-v8` file if they exist.** 🚨 - [x] https://github.com/Shopify/web/pull/84457 <hr> ### WHAT is this pull request doing? Removes deprecated v8 custom properties, functions, mixins, and maps from `stylelint-polaris` that do not exist in web (see the linked issue above for a list of these values). --------- Co-authored-by: Aaron Casanova <[email protected]>

@skparkk

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Major Changes - [Shopify#8919](Shopify#8919) [`7349d4108`](Shopify@7349d41) Thanks [@skparkk](https://github.com/skparkk)! - Added new keyboard major + minor icons ### Minor Changes - [Shopify#8924](Shopify#8924) [`4880e3ed7`](Shopify@4880e3e) Thanks [@Tal87](https://github.com/tal87)! - Added PersonalizedTextMajor icon - [Shopify#8861](Shopify#8861) [`2bc90503d`](Shopify@2bc9050) Thanks [@AlejandroE](https://github.com/AlejandroE)! - Added ExploreImagesMajor ## @shopify/[email protected] ### Major Changes - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris ### Minor Changes - [Shopify#8968](Shopify#8968) [`dbe68efb4`](Shopify@dbe68ef) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `custom-property-disallowed-list` rule ## @shopify/[email protected] ### Minor Changes - [Shopify#8936](Shopify#8936) [`a2c9b1d24`](Shopify@a2c9b1d) Thanks [@alex-page](https://github.com/alex-page)! - Renamed Inline to HorizontalStack - [Shopify#8773](Shopify#8773) [`e8c5a2243`](Shopify@e8c5a22) Thanks [@stefanlegg](https://github.com/stefanlegg)! - - Added an optional `onSpinnerChange` prop to`TextField` - Added an optional `largeStep` prop to `TextField` - Added `TextField` `Spinner` keypress interactions for Home, End, Page Up, Page Down - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8937](Shopify#8937) [`fcc543928`](Shopify@fcc5439) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `Columns` to `HorizontalGrid` - [Shopify#8938](Shopify#8938) [`289dce569`](Shopify@289dce5) Thanks [@alex-page](https://github.com/alex-page)! - Remove deprecation from `Grid` component - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8596](Shopify#8596) [`421bb49dc`](Shopify@421bb49) Thanks [@brendanrygus](https://github.com/brendanrygus)! - [Frame] Fix minimum height overflowing in iOS Webkit browsers - [Shopify#8953](Shopify#8953) [`500eed660`](Shopify@500eed6) Thanks [@zakwarsame](https://github.com/zakwarsame)! - - Added `customActivator` prop to `TopBar.UserMenu` - Added support for setting a `ReactNode` on `ActionList` `Section` `title` ### Patch Changes - [Shopify#8842](Shopify#8842) [`bd64fa583`](Shopify@bd64fa5) Thanks [@martenbjork](https://github.com/martenbjork)! - Removed the Exiting animation state from Popovers, causing them to close immediately instead of after a 100ms delay. - [Shopify#8913](Shopify#8913) [`261355f07`](Shopify@261355f) Thanks [@mrcthms](https://github.com/mrcthms)! - Tweaked the vertical alignment of elements within the `AlphaFilters` component - [Shopify#8954](Shopify#8954) [`f9366c22d`](Shopify@f9366c2) Thanks [@laurkim](https://github.com/laurkim)! - Updated custom property names to align with new component names for `HorizontalGrid`, `HorizontalStack`, and `VerticalStack` - [Shopify#8912](Shopify#8912) [`1cc47495a`](Shopify@1cc4749) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `BulkActions` to include wrapping tooltip on Popover activator - Updated dependencies \[[`4880e3ed7`](Shopify@4880e3e), [`7349d4108`](Shopify@7349d41), [`2bc90503d`](Shopify@2bc9050)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@f1a3ad7), [`80eb3ac55`](Shopify@80eb3ac), [`dbe68efb4`](Shopify@dbe68ef)]: - @shopify/[email protected] ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`f1a3ad756`](Shopify@f1a3ad7), [`80eb3ac55`](Shopify@80eb3ac), [`dbe68efb4`](Shopify@dbe68ef)]: - @shopify/[email protected] ## [email protected] ### Minor Changes - [Shopify#8876](Shopify#8876) [`090d09683`](Shopify@090d096) Thanks [@mrcthms](https://github.com/mrcthms)! - Updated `IndexFilters` to support hiding both filters and search field - [Shopify#8973](Shopify#8973) [`f1a3ad756`](Shopify@f1a3ad7) Thanks [@lgriffee](https://github.com/lgriffee)! - Enabled the `custom-property-disallowed-list` rule and added deprecated v10 custom properties. - [Shopify#8967](Shopify#8967) [`45d978e7b`](Shopify@45d978e) Thanks [@lgriffee](https://github.com/lgriffee)! - Added a version matchup table to `stylelint-polaris` documentation - [Shopify#8986](Shopify#8986) [`f70f586ee`](Shopify@f70f586) Thanks [@laurkim](https://github.com/laurkim)! - Added documentation for the `react-rename-component` codemod - [Shopify#8935](Shopify#8935) [`7f3053342`](Shopify@7f30533) Thanks [@alex-page](https://github.com/alex-page)! - Renamed `AlphaStack` to `VerticalStack` - [Shopify#8920](Shopify#8920) [`2bad4e305`](Shopify@2bad4e3) Thanks [@kyledurand](https://github.com/kyledurand)! - Added copy button to markdown headings with ids ### Patch Changes - [Shopify#8915](Shopify#8915) [`c8a130caf`](Shopify@c8a130c) Thanks [@kyledurand](https://github.com/kyledurand)! - Added scroll-margin-top to anchor links to prevent top bar overlay - [Shopify#8455](Shopify#8455) [`80eb3ac55`](Shopify@80eb3ac) Thanks [@lgriffee](https://github.com/lgriffee)! - Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris - Updated dependencies \[[`a2c9b1d24`](Shopify@a2c9b1d), [`e8c5a2243`](Shopify@e8c5a22), [`090d09683`](Shopify@090d096), [`bd64fa583`](Shopify@bd64fa5), [`f1a3ad756`](Shopify@f1a3ad7), [`261355f07`](Shopify@261355f), [`fcc543928`](Shopify@fcc5439), [`4880e3ed7`](Shopify@4880e3e), [`7349d4108`](Shopify@7349d41), [`2bc90503d`](Shopify@2bc9050), [`f9366c22d`](Shopify@f9366c2), [`289dce569`](Shopify@289dce5), [`7f3053342`](Shopify@7f30533), [`421bb49dc`](Shopify@421bb49), [`500eed660`](Shopify@500eed6), [`1cc47495a`](Shopify@1cc4749)]: - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…maps from `stylelint-polaris` (Shopify#8455) ### WHY are these changes introduced? Fixes Shopify#7622 <hr> 🚨 **Before this PR ships we need to remove the same values from the `_legacy-polaris-v8` file if they exist.** 🚨 - [x] Shopify/web#84457 <hr> ### WHAT is this pull request doing? Removes deprecated v8 custom properties, functions, mixins, and maps from `stylelint-polaris` that do not exist in web (see the linked issue above for a list of these values). --------- Co-authored-by: Aaron Casanova <[email protected]>

lgriffee added 6 commits February 21, 2023 11:34

Remove v9 legacy tokens from stylelint

f4353c7

Revert removal of --p-border-radius-wide

4123171

Remove v9 legacy functions and mixins from stylelint

a4dd865

Fix typo

8f0d63b

Remove v9 legacy mixin maps from stylelint

91fa425

Add changeset

11d7aef

lgriffee added the v11.0.0 label Feb 22, 2023

lgriffee self-assigned this Feb 22, 2023

lgriffee commented Feb 22, 2023

View reviewed changes

lgriffee added 2 commits February 22, 2023 12:27

Revert several removals

c7879f4

Fix revert

4cdece3

lgriffee requested review from alex-page and aaronccasanova February 22, 2023 22:19

lgriffee marked this pull request as ready for review February 22, 2023 22:19

lgriffee commented Mar 2, 2023

View reviewed changes

.changeset/nice-panthers-doubt.md Show resolved Hide resolved

alex-page approved these changes Mar 2, 2023

View reviewed changes

alex-page approved these changes Mar 17, 2023

View reviewed changes

Merge branch 'main' of https://github.com/Shopify/polaris into stylel…

ef49f50

…int-remove-v9-legacy

aaronccasanova approved these changes Apr 12, 2023

View reviewed changes

Update test to generic token

caa6f29

Co-Authored-By: Aaron Casanova <[email protected]>

lgriffee changed the title ~~Remove deprecated v9 custom properties, functions, mixins, and mixin maps from stylelint-polaris~~ Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris Apr 12, 2023

lgriffee commented Apr 12, 2023

View reviewed changes

.changeset/nice-panthers-doubt.md Outdated Show resolved Hide resolved

Update .changeset/nice-panthers-doubt.md

9fe2220

alex-page approved these changes Apr 12, 2023

View reviewed changes

lgriffee merged commit 80eb3ac into main Apr 13, 2023

lgriffee deleted the stylelint-remove-v9-legacy branch April 13, 2023 19:05

shopify-github-actions-access bot mentioned this pull request Apr 13, 2023

Version Packages #8929

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated v8 custom properties, functions, mixins, and mixin maps from `stylelint-polaris` #8455

Remove deprecated v8 custom properties, functions, mixins, and mixin maps from `stylelint-polaris` #8455

lgriffee commented Feb 22, 2023 •

edited

Loading

lgriffee Feb 22, 2023

lgriffee Feb 22, 2023 •

edited

Loading

lgriffee commented Apr 12, 2023

github-actions bot commented Apr 12, 2023

Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris #8455

Remove deprecated v8 custom properties, functions, mixins, and mixin maps from stylelint-polaris #8455

Conversation

lgriffee commented Feb 22, 2023 • edited Loading

WHY are these changes introduced?

WHAT is this pull request doing?

lgriffee Feb 22, 2023

Choose a reason for hiding this comment

lgriffee Feb 22, 2023 • edited Loading

Choose a reason for hiding this comment

lgriffee commented Apr 12, 2023

github-actions bot commented Apr 12, 2023

Remove deprecated v8 custom properties, functions, mixins, and mixin maps from `stylelint-polaris` #8455

Remove deprecated v8 custom properties, functions, mixins, and mixin maps from `stylelint-polaris` #8455

lgriffee commented Feb 22, 2023 •

edited

Loading

lgriffee Feb 22, 2023 •

edited

Loading