Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v10 legacy custom properties #8374

Merged
merged 38 commits into from
Apr 24, 2023

Conversation

lgriffee
Copy link
Member

@lgriffee lgriffee commented Feb 15, 2023

WHY are these changes introduced?

Fixes #8405

Closes #4826

WHAT is this pull request doing?

Removes the legacy custom properties outlined in #8405 from v11.

@lgriffee lgriffee linked an issue Feb 16, 2023 that may be closed by this pull request
@lgriffee lgriffee changed the title Remove v11 legacy custom properties Remove v11 legacy custom properties Feb 17, 2023
@lgriffee lgriffee changed the title Remove v11 legacy custom properties Remove v10 legacy custom properties Apr 12, 2023
@lgriffee
Copy link
Member Author

lgriffee commented Apr 20, 2023

✅ Need to merge #9006 before CI will pass.
✅ Also remove spacing token group once #9016 merges.

@lgriffee lgriffee marked this pull request as ready for review April 20, 2023 22:51
@lgriffee
Copy link
Member Author

lgriffee commented Apr 20, 2023

✅ Will wait on #9017 shipping so we can remove legacy motion tokens as well before shipping.

@lgriffee
Copy link
Member Author

Going to wait on shipping this until we have stylelint-polaris rules to prevent the use of legacy motion tokens.

lgriffee and others added 4 commits April 24, 2023 16:33
Co-Authored-By: Aaron Casanova <[email protected]>
Co-authored-by: Aaron Casanova <[email protected]>
Co-authored-by: Aaron Casanova <[email protected]>
@lgriffee lgriffee merged commit 37f3e2e into v11-major Apr 24, 2023
@lgriffee lgriffee deleted the remove-v11-legacy-custom-properties branch April 24, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove v10 legacy custom properties
3 participants