Migrate --p-space-0 tokens in SCSS files to 0
#8356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lgriffee
commented
Feb 17, 2023
lgriffee
force-pushed
the
migrate-v11-legacy-custom-properties
branch
from
aa432ca
to
3f46653
Compare
lgriffee
changed the title
@shopify/polaris-migrator to replace legacy v11 custom properties--p-space-0 tokens in SCSS files to 0
aaronccasanova
approved these changes
Feb 17, 2023
aveline
approved these changes
Feb 17, 2023
lgriffee
commented
Feb 17, 2023
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
### WHY are these changes introduced? While our team has decided to keep the `--p-space-0` token in our system we don't need to be using it to replace unitless zero values. ### WHAT is this pull request doing? Runs the `styles-replace-custom-property` migration from `@shopify/polaris-migrator` to replace any instances of `--p-space-0` with `0` in `polaris-react` Sass files. e.g. ```sh npx @shopify/polaris-migrator styles-replace-custom-property \ --decl="/.+/" --from="--p-space-0" --to="0" '../polaris-react/src/**/*.scss' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
While our team has decided to keep the
--p-space-0token in our system we don't need to be using it to replace unitless zero values.WHAT is this pull request doing?
Runs the
styles-replace-custom-propertymigration from@shopify/polaris-migratorto replace any instances of--p-space-0with0inpolaris-reactSass files. e.g.