-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump NodeJS supported versions to ^16.16 || ^18.13 and add engines to package.json #8201
Merged
Commits on Jan 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7ff43f4 - Browse repository at this point
Copy the full SHA 7ff43f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53b178d - Browse repository at this point
Copy the full SHA 53b178dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2ab1fb - Browse repository at this point
Copy the full SHA e2ab1fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c890078 - Browse repository at this point
Copy the full SHA c890078View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10b3223 - Browse repository at this point
Copy the full SHA 10b3223View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d05096 - Browse repository at this point
Copy the full SHA 2d05096View commit details -
3/x Enforce NodeJS versions with engines in package.json (#8202)
### WHY are these changes introduced? We currently set `engines` on the root `package.json`. The problem with this is that consumers of the library do not get this information and they can use the libraries without any warning of what version of NodeJS it supports. This change adds the engines field to each package to ensure our consumers are using supported versions of NodeJS. ### WHAT is this pull request doing? Adding the engines field to package.json files
Configuration menu - View commit details
-
Copy full SHA for 273d137 - Browse repository at this point
Copy the full SHA 273d137View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7935ed5 - Browse repository at this point
Copy the full SHA 7935ed5View commit details -
Merge branch 'bump-nodejs' of https://github.com/Shopify/polaris into…
… bump-nodejs
Configuration menu - View commit details
-
Copy full SHA for 1d02ef0 - Browse repository at this point
Copy the full SHA 1d02ef0View commit details
Commits on Jan 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8779cba - Browse repository at this point
Copy the full SHA 8779cbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08622a8 - Browse repository at this point
Copy the full SHA 08622a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eabd34 - Browse repository at this point
Copy the full SHA 7eabd34View commit details -
Configuration menu - View commit details
-
Copy full SHA for cda3ff4 - Browse repository at this point
Copy the full SHA cda3ff4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cd33ac - Browse repository at this point
Copy the full SHA 3cd33acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e91155 - Browse repository at this point
Copy the full SHA 8e91155View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.