Skip to content

Conversation

@aaronccasanova
Copy link
Member

@aaronccasanova aaronccasanova commented Sep 16, 2022

Closes #7148

Add replace-static-mixins-with-declarations migration script.

Running npx @shopify/polaris-migrator replace-static-mixins-with-declarations "**/*.scss" will replace the following mixins with declarations:

  • @include text-emphasis-subdued;
  • @include text-emphasis-strong;
  • @include text-emphasis-normal;

@aaronccasanova aaronccasanova self-assigned this Sep 16, 2022
@aaronccasanova aaronccasanova marked this pull request as ready for review September 16, 2022 22:38
@sam-b-rose
Copy link
Member

Looks great! Just needs a changeset 🦋 🚀

Copy link
Contributor

@lgriffee lgriffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯🚢✨🎉

@aaronccasanova
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@aaronccasanova
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@aaronccasanova
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@aaronccasanova aaronccasanova merged commit fbf2f88 into main Oct 5, 2022
@aaronccasanova aaronccasanova deleted the replace-static-mixins-with-declarations branch October 5, 2022 23:56
@aaronccasanova aaronccasanova changed the title Migrate static mixins Add migration to replace-static-mixins-with-declarations Oct 5, 2022
@github-actions github-actions bot mentioned this pull request Oct 5, 2022
kyledurand pushed a commit that referenced this pull request Oct 7, 2022
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/[email protected]

### Minor Changes

- [#7216](#7216)
[`fbf2f8832`](fbf2f88)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Add
migration to replace static mixins with declarations

### Patch Changes

- [#7328](#7328)
[`b31f51f25`](b31f51f)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Add
namespace support to the `replace-static-breakpoint-mixins` migration

## @shopify/[email protected]

### Minor Changes

- [#7360](#7360)
[`f7140123d`](f714012)
Thanks [@mrcthms](https://github.com/mrcthms)! - Update `IndexTable` in
sortable mode to fix visual bugs and include label Tooltips

### Patch Changes

- [#7361](#7361)
[`b1b576403`](b1b5764)
Thanks [@kyledurand](https://github.com/kyledurand)! - Use state
callback in page actions


- [#7319](#7319)
[`4b95fdc64`](4b95fdc)
Thanks [@qt314](https://github.com/qt314)! - Update the `VideoThumbnail`
play button user experience

## @shopify/[email protected]

### Patch Changes

- Updated dependencies
\[[`fbf2f8832`](fbf2f88),
[`b31f51f25`](b31f51f)]:
    -   @shopify/[email protected]

## [email protected]

### Minor Changes

- [#7254](#7254)
[`61cf086ed`](61cf086)
Thanks [@nickpresta](https://github.com/nickpresta)! - Added ability to
collapse props that have been expanded.

### Patch Changes

- [#7305](#7305)
[`b0445cf9b`](b0445cf)
Thanks [@selenehinkley](https://github.com/selenehinkley)! - Added
"Getting started" section

- Updated dependencies
\[[`f7140123d`](f714012),
[`b1b576403`](b1b5764),
[`4b95fdc64`](4b95fdc)]:
    -   @shopify/[email protected]

## [email protected]

### Patch Changes

- Updated dependencies
\[[`f7140123d`](f714012),
[`b1b576403`](b1b5764),
[`4b95fdc64`](4b95fdc)]:
    -   @shopify/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sam-b-rose sam-b-rose mentioned this pull request Oct 20, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate static mixins

3 participants