[polaris.shopify.com] Add ability to collapse types in props table. #7254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martenbjork
approved these changes
Oct 7, 2022
Member
Author
|
Awesome! Looks great! 👍 to ship! |
Merged
kyledurand
pushed a commit
that referenced
this pull request
Oct 7, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#7216](#7216) [`fbf2f8832`](fbf2f88) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Add migration to replace static mixins with declarations ### Patch Changes - [#7328](#7328) [`b31f51f25`](b31f51f) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Add namespace support to the `replace-static-breakpoint-mixins` migration ## @shopify/[email protected] ### Minor Changes - [#7360](#7360) [`f7140123d`](f714012) Thanks [@mrcthms](https://github.com/mrcthms)! - Update `IndexTable` in sortable mode to fix visual bugs and include label Tooltips ### Patch Changes - [#7361](#7361) [`b1b576403`](b1b5764) Thanks [@kyledurand](https://github.com/kyledurand)! - Use state callback in page actions - [#7319](#7319) [`4b95fdc64`](4b95fdc) Thanks [@qt314](https://github.com/qt314)! - Update the `VideoThumbnail` play button user experience ## @shopify/[email protected] ### Patch Changes - Updated dependencies \[[`fbf2f8832`](fbf2f88), [`b31f51f25`](b31f51f)]: - @shopify/[email protected] ## [email protected] ### Minor Changes - [#7254](#7254) [`61cf086ed`](61cf086) Thanks [@nickpresta](https://github.com/nickpresta)! - Added ability to collapse props that have been expanded. ### Patch Changes - [#7305](#7305) [`b0445cf9b`](b0445cf) Thanks [@selenehinkley](https://github.com/selenehinkley)! - Added "Getting started" section - Updated dependencies \[[`f7140123d`](f714012), [`b1b576403`](b1b5764), [`4b95fdc64`](4b95fdc)]: - @shopify/[email protected] ## [email protected] ### Patch Changes - Updated dependencies \[[`f7140123d`](f714012), [`b1b576403`](b1b5764), [`4b95fdc64`](4b95fdc)]: - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Hot on the heels of #6757 being merged, this change introduces the ability to collapse props after being expanded. This allows users to expand ("explore") and then collapse ("focus") props as needed depending on the types they want to see.
Before
2022-09-22_12-05-35.mp4
After
2022-09-22_12-07-20.mp4
WHAT is this pull request doing?
TypeTablein<AnimatePresence>per Framer's instruction when using exit animations ondiv.motionas well as akey.hasBenExpandedtohasBeenExpanded-- think this was a typo.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Run the Polaris docs:
dev upcd polaris.shopify.com && yarn run dev🎩 checklist
README.mdwith documentation changes