sewing-kit-next build #4424
sewing-kit-next build #4424
Conversation
ghost
added
the
cla-needed
| @@ -2,8 +2,12 @@ | |||
| node_modules | |||
| /.sewing-kit | |||
| /build | |||
| /dist | |||
| /build-internal | |||
There was a problem hiding this comment.
build-internal is a much better place. Thanks @BPScott
| // Run Sk build to generate everything | ||
| run(`yarn run skn build`); |
There was a problem hiding this comment.
Love this clean up with the preAndPostBuildPlugin. Could we remove this file all together and just run this in the package.json?
ghost
removed
the
cla-needed
|
Running into some surprises with the style.css load order being changed around, I'll be digging into that, but the rest is seems to be good |
alex-page
force-pushed
the
v7.0.0-release
branch
from
8559933
to
d111db6
Compare
BPScott
force-pushed
the
v7.0.0-release
branch
from
d111db6
to
8559933
Compare
- Temp file folder moves from /build to /build-internal - Build output to be published folder moves from /dist to /build - css file location changed from /dist/styles.css to build/esm/styles.css - Remove the concept of having the build-only tsconfig.build.json. tsconfig.json is build as part of the build, and puts test types files into the buiild folder. We exclude those files with the files array in package.json
When using preserveModules, the array of bundles passed to generateBundle contains every file, instead of just the entrypoint. this means we need a different tactic to build the ordered list of imported css content. Instead of looking at the modules list of the single output file, we have find the entrypoint file, and find its imports, then lookup the files that imports and so on to build the ordered list of imports.
|
Found the root cause of the styles.css order mangling issue and found the fix (by which I mean I remembered others ran into a similar issue back in the day in egoist/rollup-plugin-postcss#295). See e8f5edb @dahukish This is super important: Can you please apply that fix within global-nav and within the styles plugin that you're extracting into sewing-kit-next. Without this fix the ordering of generated styles.css files is straight up totally wrong. |
|
Merging this with failing checks as they're expected.
|
WHY are these changes introduced?
Use sewing-kit-next for our build process, rather than having a bespoke rollup config
Being a showcase for the modern (albeit getting the breaking changes in as part of a major version bump.
Migrating from a bespoke rollup build to use sewing-kit-next to perform the build.
Parts of this are still a bit lumpy but will be able to be improved without any breaking change in the near future.
WHAT is this pull request doing?
This PR replaces our bespoke rollup build with using sewing-kit-next (which still uses rollup under the hood). This doesn't look too different at the moment - we still need bespoke code for css compilation for instance and rollup plugins for image handliing, but in the near future this code shall be extracted into a reusable skn plugin that configures rollup in an opinionated way.
Previously package content was built into
dist, and temp, cache and storybook output was placed intobuild. The sewing-kit-next plugin we're using is opinionated and places package content into the build folder. Thus we have to find somewhere else for those temp/cache/storybook files to live. The following changes have been made:/buildto/build-internal/distto/buildThis change of the package content location means that consumers who previously imported styles.css now need to use the new path