Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text-transform as a failure in polaris-stylelint #8241

Closed
alex-page opened this issue Feb 1, 2023 · 0 comments · Fixed by #8244
Closed

Add text-transform as a failure in polaris-stylelint #8241

alex-page opened this issue Feb 1, 2023 · 0 comments · Fixed by #8244
Assignees
@sam-b-rose

Comments

@alex-page
Copy link
Member

Issue summary

Developers shouldn't be using text-transform in the admin. They should be updating translation files or using the Text component without capitalisation. This issue would enforce this direction.

Expected behavior

Developers get an error when using text-transform

Actual behavior

Developers are using text-transform everywhere
@sam-b-rose sam-b-rose mentioned this issue Feb 2, 2023
Merged
@chloerice chloerice assigned chloerice and sam-b-rose and unassigned chloerice Feb 2, 2023
@sam-b-rose sam-b-rose mentioned this issue Feb 2, 2023
Merged
sam-b-rose added a commit that referenced this issue Feb 2, 2023
@sam-b-rose
Disallow text transform in stylelint-polaris coverage rules (#8244)
0ee4325 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #8241 <!-- link to issue if one exists -->

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

Adds the `text-transform` to the disallow properties list of the
`stylelint-polaris` plugin.
juzser pushed a commit to juzser/polaris that referenced this issue Jul 27, 2023
@sam-b-rose @juzser
Disallow text transform in stylelint-polaris coverage rules (Shopify#…
92ca077 
…8244)

<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes Shopify#8241 <!-- link to issue if one exists -->

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

Adds the `text-transform` to the disallow properties list of the
`stylelint-polaris` plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sam-b-rose sam-b-rose

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow text transform in stylelint-polaris coverage rules Shopify/polaris
3 participants
@sam-b-rose @chloerice @alex-page