Config for runtime: automatic

Shopify · Mar 13, 2023 · f0b3159 · f0b3159
1 parent 628cc5d
commit f0b3159
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 6 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -55,6 +55,11 @@ module.exports = {
     'react/button-has-type': 'off',
     'react/no-array-index-key': 'off',
     'react/no-unsafe': ['error', {checkAliases: true}],
+
+    // These can be removed when eslint-plugin-react is updated
+    'react/jsx-uses-react': 'off',
+    'react/react-in-jsx-scope': 'off',
+
     '@shopify/jsx-no-complex-expressions': 'off',
     '@shopify/jsx-prefer-fragment-wrappers': 'off',
     '@shopify/no-ancestor-directory-import': 'error',
@@ -165,7 +170,6 @@ module.exports = {
       files: ['polaris.shopify.com/**/*'],
       extends: 'plugin:@next/eslint-plugin-next/recommended',
       rules: {
-        'react/react-in-jsx-scope': 'off',
         '@shopify/jsx-no-hardcoded-content': 'off',
         'import/no-default-export': 'off',
       },

diff --git a/babel.config.js b/babel.config.js
@@ -1,15 +1,23 @@
 /**
  * @type {import('@babel/core').TransformOptions}
  */
-module.exports = function () {
+module.exports = function (api) {
+  api.cache(true);
+
   return {
     presets: [
       [
         '@babel/preset-env',
         {useBuiltIns: 'entry', corejs: '3.0', bugfixes: true},
       ],
       ['@babel/preset-typescript'],
-      ['@babel/preset-react', {runtime: 'automatic', useBuiltIns: true}],
+      [
+        '@babel/preset-react',
+        {
+          runtime: 'automatic',
+          useBuiltIns: true,
+        },
+      ],
     ],
     assumptions: {
       setPublicClassFields: true,

diff --git a/polaris-migrator/tsconfig.json b/polaris-migrator/tsconfig.json
@@ -6,7 +6,7 @@
     "emitDeclarationOnly": true,
     "outDir": "dist/types",
     "rootDir": "src",
-    "jsx": "react",
+    "jsx": "react-jsx",
     "types": ["node", "jest"]
   },
   "include": ["src"],

diff --git a/polaris-react/tsconfig.json b/polaris-react/tsconfig.json
@@ -9,7 +9,8 @@
     "strictFunctionTypes": false,
     "paths": {
       "tests/*": ["./tests/*"]
-    }
+    },
+    "jsx": "react-jsx"
   },
   "include": [
     "./src",

diff --git a/polaris.shopify.com/tsconfig.json b/polaris.shopify.com/tsconfig.json
@@ -15,7 +15,7 @@
     "moduleResolution": "node",
     "resolveJsonModule": true,
     "isolatedModules": true,
-    "jsx": "preserve",
+    "jsx": "react-jsx",
     "composite": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true