Skip to content

[Typography foundations] Temporarily remove console warnings for deprecated type components #7808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2022
+5 −42
Merged

[Typography foundations] Temporarily remove console warnings for deprecated type components #7808

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0422f2d
[Typography foundations] Temporarily remove console warnings for depr…
laurkim Nov 29, 2022
d88b1d3
Add changeset
laurkim Nov 29, 2022
ca57000
Remove deprecation and todo comments
aaronccasanova Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/friendly-geese-clean.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Temporarily removed console warnings for deprecated typography components
13 changes: 7 additions & 6 deletions polaris-react/src/components/Caption/Caption.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@ export interface CaptionProps {
* https://polaris.shopify.com/components/text
*/
export function Caption({children}: CaptionProps) {
if (process.env.NODE_ENV === 'development') {
// eslint-disable-next-line no-console
console.warn(
'Deprecation: The `Caption` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
);
}
// TODO: Re-add console warnings after migrations are complete
// if (process.env.NODE_ENV === 'development') {
// // eslint-disable-next-line no-console
// console.warn(
// 'Deprecation: The `Caption` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
// );
// }

return <p className={styles.Caption}>{children}</p>;
}
13 changes: 7 additions & 6 deletions polaris-react/src/components/DisplayText/DisplayText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,13 @@ export function DisplayText({
size && styles[variationName('size', size)],
);

if (process.env.NODE_ENV === 'development') {
// eslint-disable-next-line no-console
console.warn(
'Deprecation: The `DisplayText` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
);
}
// TODO: Re-add console warnings after migrations are complete
// if (process.env.NODE_ENV === 'development') {
// // eslint-disable-next-line no-console
// console.warn(
// 'Deprecation: The `DisplayText` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
// );
// }

return <Element className={className}>{children}</Element>;
}
13 changes: 7 additions & 6 deletions polaris-react/src/components/Heading/Heading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,13 @@ export interface HeadingProps {
* https://polaris.shopify.com/components/text
*/
export function Heading({element: Element = 'h2', children, id}: HeadingProps) {
if (process.env.NODE_ENV === 'development') {
// eslint-disable-next-line no-console
console.warn(
'Deprecation: The `Heading` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
);
}
// TODO: Re-add console warnings after migrations are complete
// if (process.env.NODE_ENV === 'development') {
// // eslint-disable-next-line no-console
// console.warn(
// 'Deprecation: The `Heading` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
// );
// }

return (
<Element className={styles.Heading} id={id}>
Expand Down
13 changes: 7 additions & 6 deletions polaris-react/src/components/Subheading/Subheading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,13 @@ export function Subheading({
}: SubheadingProps) {
const ariaLabel = typeof children === 'string' ? children : undefined;

if (process.env.NODE_ENV === 'development') {
// eslint-disable-next-line no-console
console.warn(
'Deprecation: The `Subheading` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
);
}
// TODO: Re-add console warnings after migrations are complete
// if (process.env.NODE_ENV === 'development') {
// // eslint-disable-next-line no-console
// console.warn(
// 'Deprecation: The `Subheading` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
// );
// }

return (
<Element aria-label={ariaLabel} className={styles.Subheading}>
Expand Down
13 changes: 7 additions & 6 deletions polaris-react/src/components/TextStyle/TextStyle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,13 @@ export function TextStyle({variation, children}: TextStyleProps) {
variation === VariationValue.Code && styles.code,
);

if (process.env.NODE_ENV === 'development') {
// eslint-disable-next-line no-console
console.warn(
'Deprecation: The `TextStyle` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
);
}
// TODO: Re-add console warnings after migrations are complete
// if (process.env.NODE_ENV === 'development') {
// // eslint-disable-next-line no-console
// console.warn(
// 'Deprecation: The `TextStyle` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
// );
// }

const Element = variationElement(variation);

Expand Down
13 changes: 7 additions & 6 deletions polaris-react/src/components/VisuallyHidden/VisuallyHidden.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@ export interface VisuallyHiddenProps {
* https://polaris.shopify.com/components/text
*/
export function VisuallyHidden({children}: VisuallyHiddenProps) {
if (process.env.NODE_ENV === 'development') {
// eslint-disable-next-line no-console
console.warn(
'Deprecation: The VisuallyHidden` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
);
}
// TODO: Re-add console warnings after migrations are complete
// if (process.env.NODE_ENV === 'development') {
// // eslint-disable-next-line no-console
// console.warn(
// 'Deprecation: The VisuallyHidden` component has been deprecated. Use the `Text` component instead. See the Polaris component guide on how to use `Text`. https://polaris.shopify.com/components/text',
// );
// }

return <span className={styles.VisuallyHidden}>{children}</span>;
}