Skip to content

[Bleed] Fix examples #7747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2022
Merged

[Bleed] Fix examples #7747

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ad6789
fix bleed examples
kyledurand Nov 17, 2022
fe82966
add changeset
kyledurand Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions polaris.shopify.com/pages/examples/bleed-all-directions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function BleedAllDirectionsExample() {
return (
<Box background="surface" border="base" padding="4">
<Bleed vertical="4" horizontal="4">
<Box background="surface" border="base" padding="5">
<Bleed vertical="5">
<Placeholder label="All directions" />
</Bleed>
</Box>
Expand Down
16 changes: 8 additions & 8 deletions polaris.shopify.com/pages/examples/bleed-specific-direction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,23 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';
function BleedSpecificDirectionExample() {
return (
<AlphaStack spacing="6" fullWidth>
<Box background="surface" border="base" padding="4">
<Bleed top="4">
<Box background="surface" border="base" padding="5">
<Bleed top="5">
<Placeholder label="Top" />
</Bleed>
</Box>
<Box background="surface" border="base" padding="4">
<Bleed bottom="4">
<Box background="surface" border="base" padding="5">
<Bleed bottom="5">
<Placeholder label="Bottom" />
</Bleed>
</Box>
<Box background="surface" border="base" padding="4">
<Bleed left="4">
<Box background="surface" border="base" padding="5">
<Bleed left="5" right="0">
<Placeholder label="Left" />
</Bleed>
</Box>
<Box background="surface" border="base" padding="4">
<Bleed right="4">
<Box background="surface" border="base" padding="5">
<Bleed right="5" left="0">
<Placeholder label="Right" />
</Bleed>
</Box>
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/bleed-vertical.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';
function BleedVerticalExample() {
return (
<Box background="surface" border="base" padding="4">
<Bleed vertical="4">
<Bleed horizontal="0" vertical="4">
<Placeholder label="Vertical" />
</Bleed>
</Box>
Expand Down