[polaris.shopify.com] Get latest styles for local development #7554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyledurand
commented
Oct 27, 2022
| @@ -0,0 +1,10 @@ | |||
| import fs from 'fs'; | |||
|
|
|||
| const builtStylesPath = '../polaris-react/build/esm/styles.css'; | |||
Member
Author
There was a problem hiding this comment.
I'm assuming Polaris is always built when yarn dev runs, otherwise other things would fail as well, right?
Member
There was a problem hiding this comment.
Only if it happens at the root of the monorepo. This could be a little bit confusing if someone is running just the website.
Member
Author
|
This has just been proven to be important in production as well. unpkg.com was not serving up our css for ~1.5hr. |
Member
|
The way I hoped we would resolve this would be adding |
Merged
Member
Author
|
Closing in favour of global styles approach #7659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling css from
https://unpkg.com/@shopify/polaris@latest/build/esm/styles.cssmeans that css can get out of sync when developing.Why this is important
We're currently developing documentation around alpha / beta components. These components are changing and our docs will too, let's make sure the css is synced so we're not seeing weird stuff!