Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nice-boxes-jam.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'polaris.shopify.com': patch
---

Fix tile image and increase example widths on alpha components
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/alpha-stack-default.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function AlphaStackExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<AlphaStack>
<Text variant="heading4xl" as="h2">
AlphaStack
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function AlphaStackWithAlignExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with align start
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function AlphaStackWithFullWidthChildrenExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<AlphaStack fullWidth>
<Text variant="heading4xl" as="h2">
AlphaStack
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function AlphaStackWithSpacingExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with spacing 0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const styles = {

function BleedAllDirectionsExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Box background="surface" border="base" padding="4">
<Bleed spacing="6">
<div style={styles}>
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/bleed-horizontal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const styles = {

function BleedHorizontalExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Box background="surface" border="base" padding="4">
<Bleed horizontal="6">
<div style={styles}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const styles = {

function BleedSpecificDirectionExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Box background="surface" border="base" padding="4">
<Bleed top="6">
<div style={styles}>
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/bleed-vertical.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const styles = {

function BleedVerticalExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Box background="surface" border="base" padding="4">
<Bleed vertical="6">
<div style={styles}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function ColorPickerWithTransparentValueExample() {
});

return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<ColorPicker fullWidth onChange={setColor} color={color} allowAlpha />
</div>
);
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/columns-default.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function ColumnsExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Columns columns={{xs: 1, sm: 2, md: 3, lg: 6}} spacing={{xs: '2'}}>
<div style={{background: 'var(--p-surface-success)'}}>Column one</div>
<div style={{background: 'var(--p-surface-success)'}}>Column two</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function ColumnsWithVaryingGapExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Columns
columns={{xs: 3}}
spacing={{xs: '025', sm: '05', md: '1', lg: '2', xl: '4'}}
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/content-block-width.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function ContentBlockWidthExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<ContentBlock width="md">
<Box background="surface" borderRadius="2" padding="5" shadow="card">
<Text variant="bodySm" as="h3" alignment="center">
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/inline-default.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function InlineExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Inline>
<Text variant="heading4xl" as="h2">
Inline
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/inline-with-align-y.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function InlineWithAlignYExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with alignY top
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/inline-with-align.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function InlineWithAlignExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with align start
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/tiles-with-columns.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const children = Array.from(Array(8)).map((ele, index) => (

function TilesWithColumnsExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Tiles columns={{xs: 4}} gap={{xs: '2'}}>
{children}
</Tiles>
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/tiles-with-spacing.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const children = Array.from(Array(2)).map((ele, index) => (

function TilesWithSpacingExample() {
return (
<div style={{width: '500px'}}>
<div style={{width: '100%'}}>
<Tiles columns={{xs: 1}} gap={{xs: '5'}}>
{children}
</Tiles>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
[data-is-current-result='true'] &,
[data-is-current-result]:hover & {
box-shadow: inset 0 1px rgb(255 255 255 / 15%), 0 20px 50px rgb(0 0 0);
mix-blend-mode: plus-lighter;
Copy link
Member Author

@kyledurand kyledurand Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martenbjork I'm going to ship this but meant to bring it to your attention yesterday. This hover effect was reducing contrast to the point where I couldn't see some lighter components in the thumbnails. There's probably a better solution here but I'll leave that with you

before.mp4
after.mp4

animation: fade-in 0.1s both ease-out;
background-color: rgba(255, 255, 255, 0.175);
}
Expand Down