Skip to content

[polaris.shopify.com] Fix references to Box margin in alpha examples #7436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2022
Merged

[polaris.shopify.com] Fix references to Box margin in alpha examples #7436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d1ccc5
[polaris.shopify.com] Fix references to Box `margin` in alpha examples
laurkim Oct 18, 2022
7828129
Add changeset
laurkim Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-carrots-heal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'polaris.shopify.com': patch
---

Fix references to `Box` margin props in alpha layout examples
6 changes: 3 additions & 3 deletions polaris.shopify.com/pages/examples/alpha-stack-with-align.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';
function AlphaStackWithAlignExample() {
return (
<div style={{width: '500px'}}>
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with align start
</Text>
Expand All @@ -24,7 +24,7 @@ function AlphaStackWithAlignExample() {
</AlphaStack>
</Box>
<hr />
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with align center
</Text>
Expand All @@ -42,7 +42,7 @@ function AlphaStackWithAlignExample() {
</AlphaStack>
</Box>
<hr />
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with align end
</Text>
Expand Down
6 changes: 3 additions & 3 deletions polaris.shopify.com/pages/examples/alpha-stack-with-spacing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';
function AlphaStackWithSpacingExample() {
return (
<div style={{width: '500px'}}>
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with spacing 0
</Text>
Expand All @@ -24,7 +24,7 @@ function AlphaStackWithSpacingExample() {
</AlphaStack>
</Box>
<hr />
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with spacing 4
</Text>
Expand All @@ -42,7 +42,7 @@ function AlphaStackWithSpacingExample() {
</AlphaStack>
</Box>
<hr />
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with spacing 10
</Text>
Expand Down
8 changes: 4 additions & 4 deletions polaris.shopify.com/pages/examples/inline-with-align-y.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';
function InlineWithAlignYExample() {
return (
<div style={{width: '500px'}}>
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with alignY top
</Text>
Expand All @@ -22,7 +22,7 @@ function InlineWithAlignYExample() {
</Inline>
</Box>
<hr />
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with alignY center
</Text>
Expand All @@ -38,7 +38,7 @@ function InlineWithAlignYExample() {
</Inline>
</Box>
<hr />
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with alignY bottom
</Text>
Expand All @@ -54,7 +54,7 @@ function InlineWithAlignYExample() {
</Inline>
</Box>
<hr />
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with alignY baseline
</Text>
Expand Down
6 changes: 3 additions & 3 deletions polaris.shopify.com/pages/examples/inline-with-align.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';
function InlineWithAlignExample() {
return (
<div style={{width: '500px'}}>
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with align start
</Text>
Expand All @@ -22,7 +22,7 @@ function InlineWithAlignExample() {
</Inline>
</Box>
<hr />
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with align center
</Text>
Expand All @@ -38,7 +38,7 @@ function InlineWithAlignExample() {
</Inline>
</Box>
<hr />
<Box marginBottom="2">
<Box paddingBottom="2">
<Text variant="bodySm" as="h3">
with align end
</Text>
Expand Down