Skip to content

Conversation

@aaronccasanova
Copy link
Member

@aaronccasanova aaronccasanova commented Oct 5, 2022

WHAT is this pull request doing?

Breaking out some key abstractions from PR #7335 so other migration folks can start using them!

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@aaronccasanova aaronccasanova added 🤖Skip Changelog Causes CI to ignore changelog update check. #gsd:29805 labels Oct 5, 2022
@aaronccasanova aaronccasanova self-assigned this Oct 5, 2022
Copy link
Contributor

@lgriffee lgriffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these changes!!! ❤️✨🚀🎉 Thanks so much for creating a basic rem() replacement function! It's going to be super helpful for gap length replacements 🙏🏻

Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating these awesome utilities! Will be super useful 🔧 🧰

@aaronccasanova aaronccasanova marked this pull request as ready for review October 5, 2022 17:13
@aaronccasanova aaronccasanova merged commit 33584a9 into main Oct 5, 2022
@aaronccasanova aaronccasanova deleted the add-migration-utils branch October 5, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖Skip Changelog Causes CI to ignore changelog update check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants