Skip to content

Rename AlphaCard shadow prop #7325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aveline merged 2 commits into from
Oct 3, 2022
Merged

Rename AlphaCard shadow prop #7325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
418d5e5
Rename `AlphaCard` shadow prop
aveline Oct 3, 2022
cfd193d
Create selfish-poets-lick.md
aveline Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/selfish-poets-lick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@shopify/polaris': patch
'polaris.shopify.com': patch
---

Renamed `AlphaCard` `shadow` prop
2 changes: 1 addition & 1 deletion polaris-react/src/components/AlphaCard/AlphaCard.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export function BorderRadiusRoundedAbove() {

export function Flat() {
return (
<AlphaCard elevation="transparent">
<AlphaCard shadow="transparent">
<AlphaStack spacing="5">
<Text as="h3" variant="headingMd">
Online store dashboard
Expand Down
11 changes: 4 additions & 7 deletions polaris-react/src/components/AlphaCard/AlphaCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ import React from 'react';
import {useBreakpoints} from '../../utilities/breakpoints';
import {Box} from '../Box';

type CardElevationTokensScale = Extract<
DepthShadowAlias,
'card' | 'transparent'
>;
type CardShadowTokensScale = Extract<DepthShadowAlias, 'card' | 'transparent'>;

type CardBackgroundColorTokenScale = Extract<
ColorsTokenName,
Expand All @@ -25,7 +22,7 @@ export interface AlphaCardProps {
children?: React.ReactNode;
background?: CardBackgroundColorTokenScale;
hasBorderRadius?: boolean;
elevation?: CardElevationTokensScale;
shadow?: CardShadowTokensScale;
padding?: SpacingSpaceScale;
roundedAbove?: BreakpointsAlias;
}
Expand All @@ -34,7 +31,7 @@ export const AlphaCard = ({
children,
background = 'surface',
hasBorderRadius: hasBorderRadiusProp = true,
elevation = 'card',
shadow = 'card',
padding = '5',
roundedAbove,
}: AlphaCardProps) => {
Expand All @@ -51,7 +48,7 @@ export const AlphaCard = ({
<Box
background={background}
padding={padding}
shadow={elevation}
shadow={shadow}
{...(hasBorderRadius && {borderRadius: defaultBorderRadius})}
>
{children}
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/alpha-card-flat.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';

function AlphaCardExample() {
return (
<AlphaCard elevation="transparent">
<AlphaCard shadow="transparent">
<AlphaStack spacing="5">
<Text as="h3" variant="headingMd">
Online store dashboard
Expand Down