Alpha card props #7314
Merged
Alpha card props #7314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
laurkim
force-pushed
the
layout-foundations-prototype
branch
from
8ebd378 to
ea250a9
Compare
aveline
force-pushed
the
alpha-card-props
branch
from
41fb122 to
816bde2
Compare
Contributor
|
/snapit |
Contributor
|
🫰✨ Thanks @laurkim! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
laurkim
approved these changes
Sep 30, 2022
Contributor
laurkim
left a comment
laurkim
left a comment
There was a problem hiding this comment.
I think the get-props script needs to be run to pick up the new prop name. I'm still seeing backgroundColor when running the styleguide locally after running yarn && yarn build.
Otherwise lgtm! 👍
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @aveline! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Rename
AlphaCardbackground prop for consistency