Skip to content

Conversation

@chazdean
Copy link
Contributor

@chazdean chazdean commented Sep 26, 2022

WHY are these changes introduced?

Fixes #7258

WHAT is this pull request doing?

Adds alpha page and examples for Bleed component

Bleed alpha page Bleed alpha page

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@chazdean chazdean requested review from aveline and laurkim September 26, 2022 15:33
@chazdean chazdean changed the title [WIP][Layout foundations] Add alpha page in style guide for Box [WIP][Layout foundations] Add alpha page in style guide for Bleed Sep 26, 2022
@chazdean
Copy link
Contributor Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @chazdean! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@chazdean chazdean requested a review from sarahill September 26, 2022 17:05
@chazdean chazdean changed the title [WIP][Layout foundations] Add alpha page in style guide for Bleed [Layout foundations] Add alpha page in style guide for Bleed Sep 26, 2022
@chazdean chazdean marked this pull request as ready for review September 26, 2022 17:07
@chazdean chazdean self-assigned this Sep 26, 2022
@laurkim laurkim self-requested a review September 26, 2022 19:11
Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs to be rebased to resolve conflicts to the props.json file from the layout-foundations-prototype branch.

@chazdean chazdean force-pushed the feat/add-bleed-alpha-page branch from 13b72aa to 08bb68d Compare September 26, 2022 19:32
@laurkim laurkim self-requested a review September 26, 2022 19:54
Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 💯

@chazdean chazdean merged commit cc9dca4 into layout-foundations-prototype Sep 26, 2022
@chazdean chazdean deleted the feat/add-bleed-alpha-page branch September 26, 2022 19:56
laurkim added a commit that referenced this pull request Sep 30, 2022
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #7258 <!-- link to issue if one exists -->

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

Adds alpha page and examples for `Bleed` component

<details>
      <summary>Bleed alpha page</summary>
<img
src="https://user-images.githubusercontent.com/59836805/192337493-298b15a6-6622-452f-89ac-d6a90110d25c.gif"
alt="Bleed alpha page">
    </details>


<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

Co-authored-by: Lo Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants