[Layout foundations] Add alpha pages in style guide for Box, Inline, Columns, Stack, and Tile #7261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurkim
added
#gsd:30116
polaris.shopify.com
🤖Skip Changelog
Contributor
size-limit report 📦
|
laurkim
force-pushed
the
lo/add-styleguide-pages
branch
2 times, most recently
from
85f3761 to
1f74ffb
Compare
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @laurkim! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
laurkim
force-pushed
the
lo/add-styleguide-pages
branch
3 times, most recently
from
c9575cb to
101df9f
Compare
laurkim
changed the title
laurkim
force-pushed
the
lo/add-styleguide-pages
branch
from
101df9f to
b378498
Compare
sarahill
approved these changes
Sep 23, 2022
Contributor
sarahill
left a comment
sarahill
left a comment
There was a problem hiding this comment.
These feel good! I'm taking a deeper look and will create an issue with any suggestions to follow this up with ✅
aveline
approved these changes
Sep 23, 2022
polaris.shopify.com/src/components/PolarisExampleWrapper/PolarisExampleWrapper.tsx
Outdated
Show resolved
Hide resolved
laurkim
force-pushed
the
lo/add-styleguide-pages
branch
from
b378498 to
00466d2
Compare
laurkim
force-pushed
the
lo/add-styleguide-pages
branch
from
00466d2 to
5ad5538
Compare
laurkim
force-pushed
the
lo/add-styleguide-pages
branch
from
5ad5538 to
883b790
Compare
laurkim
added a commit
that referenced
this pull request
Sep 30, 2022
…Columns, Stack, and Tile (#7261) Resolves #7256. We are planning on shipping the `layout-foundations-prototype` page and need pages in the style guide that clearly designates the layout components are still in alpha. Adds alpha pages and examples for Box, Inline, Columns, AlphaStack, and Tile. <details> <summary>AlphaStack alpha page</summary> <img src="https://user-images.githubusercontent.com/26749317/191867995-8dc31ad2-9c2c-4a0e-8480-dbbac5b52034.gif" alt="AlphaStack alpha page"> </details> <details> <summary>Box alpha page</summary> <img src="https://user-images.githubusercontent.com/26749317/191868352-8bc6681e-8cf1-41bd-8af2-3d4b5794e14a.gif" alt="Box alpha page"> </details> <details> <summary>Columns alpha page</summary> <img src="https://user-images.githubusercontent.com/26749317/191868186-bbe37c93-a12d-4ba4-8ef8-1272db7e3c9e.gif" alt="Columns alpha page"> </details> <details> <summary>Inline alpha page</summary> <img src="https://user-images.githubusercontent.com/26749317/191868199-92827ca0-9eb0-49f4-b4b5-2c20b9360b79.gif" alt="Inline alpha page"> </details> <details> <summary>Tile alpha page</summary> <img src="https://user-images.githubusercontent.com/26749317/191868218-6e537b86-321c-472f-a559-f75e815e0ec2.gif" alt="Tile alpha page"> </details> <!-- ℹ️ Delete the following for small / trivial changes --> 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) In your terminal: ```script // in `polaris` root directory $ yarn && yarn build $ cd polaris.shopify.com $ yarn && yarn dev ``` - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves #7256.
We are planning on shipping the
layout-foundations-prototypepage and need pages in the style guide that clearly designates the layout components are still in alpha.WHAT is this pull request doing?
Adds alpha pages and examples for Box, Inline, Columns, AlphaStack, and Tile.
AlphaStack alpha page
Box alpha page
Columns alpha page
Inline alpha page
Tile alpha page
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
In your terminal:
🎩 checklist
README.mdwith documentation changes