Skip to content

Conversation

@SeanyB
Copy link
Contributor

@SeanyB SeanyB commented Aug 11, 2022

Update the Foundations-Design-Space page to use up-to-date space token names and range.

WHY are these changes introduced?

The space values do not currently match the actual token names.

WHAT is this pull request doing?

NOTE: This still needs an update to the illustration.

Before:
Screen Shot 2022-08-11 at 4 08 27 PM

After:

Screen Shot 2022-08-11 at 4 08 10 PM

🎩 checklist

Updates the Foundations-Design-Space page to use up-to-date `space` token names and range.
@ghost
Copy link

ghost commented Aug 11, 2022

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@SeanyB SeanyB requested a review from alex-page August 11, 2022 20:48
@SeanyB SeanyB merged commit be54da6 into main Aug 11, 2022
@SeanyB SeanyB deleted the space-tokens branch August 11, 2022 20:59
@ghost
Copy link

ghost commented Aug 11, 2022

🎉 Thanks for your contribution to Polaris!

@SeanyB SeanyB restored the space-tokens branch February 13, 2023 15:48
@lgriffee lgriffee deleted the space-tokens branch September 13, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants