-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Create @shopify/polaris-migrator package
#6852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
52fb3c4 to
4988fb5
Compare
4988fb5 to
9295480
Compare
polaris-migrator/src/migrations/replace-sass-spacing/replace-sass-spacing.ts
Outdated
Show resolved
Hide resolved
a9bab90 to
55a2ede
Compare
023da8b to
e4256e7
Compare
size-limit report 📦
|
8a0bbd3 to
8d104bc
Compare
|
/snapit |
|
🫰✨ Thanks @samrose3! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
8d104bc to
2872c05
Compare
|
/snapit |
|
🫰✨ Thanks @samrose3! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
2872c05 to
f28f481
Compare
|
I realised an edge case: We would'nt want to trivially transform the cases where it's doing basic sass math: |
d954107 to
de1a841
Compare
c226c52 to
6438668
Compare
6438668 to
9ff32a3
Compare
532b0ba to
591da07
Compare
591da07 to
ea71bbb
Compare
ea71bbb to
1d6c456
Compare
1d6c456 to
ac2ed4e
Compare
ac2ed4e to
9d17603
Compare
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Updates the `yarn.lock` to properly resolved dependencies. This fixes a mistake in rebase/updating then merging the #6852
Closes #6943
Adds the beginnings of the
@shopify/polaris-migratorpackage. This package applies code transformations to help updatePolaris apps and the Polaris codebase.
Usage
Run tests for
@shopify/polaris-migratoryarn test --filter=@shopify/polaris-migratorOriginal PR branch: #6701