Skip to content

Conversation

@sam-b-rose
Copy link
Member

@sam-b-rose sam-b-rose commented Aug 4, 2022

Closes #6943

Adds the beginnings of the @shopify/polaris-migrator package. This package applies code transformations to help update
Polaris apps and the Polaris codebase.

Usage

npx @shopify/polaris-migrator <migration> <path>

Run tests for @shopify/polaris-migrator

yarn test --filter=@shopify/polaris-migrator 

Original PR branch: #6701

@sam-b-rose sam-b-rose force-pushed the polaris-migrator branch 2 times, most recently from 52fb3c4 to 4988fb5 Compare August 4, 2022 21:49
@sam-b-rose sam-b-rose force-pushed the polaris-migrator branch 2 times, most recently from a9bab90 to 55a2ede Compare August 5, 2022 15:31
@sam-b-rose sam-b-rose force-pushed the polaris-migrator branch 2 times, most recently from 023da8b to e4256e7 Compare August 5, 2022 16:35
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

size-limit report 📦

Path Size
polaris-react-cjs 198.94 KB (0%)
polaris-react-esm 133.35 KB (0%)
polaris-react-esnext 188.58 KB (0%)
polaris-react-css 41.81 KB (0%)

@sam-b-rose sam-b-rose force-pushed the polaris-migrator branch 2 times, most recently from 8a0bbd3 to 8d104bc Compare August 5, 2022 18:00
@sam-b-rose
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

🫰✨ Thanks @samrose3! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@sam-b-rose
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

🫰✨ Thanks @samrose3! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@BPScott
Copy link
Member

BPScott commented Aug 8, 2022

I realised an edge case: We would'nt want to trivially transform the cases where it's doing basic sass math: margin: spacing() + spacing(). In Sass this would compile and work at runtime; however var(--spacing-base) + var(--spacing-base) would compile, but would produce meaningless code that would break at runtime.

@sam-b-rose sam-b-rose added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Sep 6, 2022
@sam-b-rose sam-b-rose merged commit 996e4fa into main Sep 6, 2022
@sam-b-rose sam-b-rose deleted the polaris-migrator branch September 6, 2022 19:10
sam-b-rose added a commit that referenced this pull request Sep 7, 2022
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Updates the `yarn.lock` to properly resolved dependencies. This fixes a
mistake in rebase/updating then merging the #6852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖Skip Changelog Causes CI to ignore changelog update check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create prototype @shopify/polaris-migrator package

4 participants