Button Component - Icon on the right for external links

[stephenshop]

Feature request summary

Would it be possible to add the ability to align the icon of the button on the right hand side for buttons intended to open external links.

Such as:

Rationale

From a consistency point of view, external links add the icon on the right hand side.

---

🌟 Feature requests that are not yet planned will be closed. We then use the issue’s 👍 upvotes to track and set priorities. See the contribution guidelines for more information.

👋 Thanks for opening your first issue. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

[martenbjork]

Hi Stephen! I don't have strong opinions myself, but I'll ping @sarahill and link to this discussion on the use of external links: #6558

[joellesasseville]

For more context:

In SFN (first party app), we often need to link merchants to external services or are forced to open admin pages in another tab, due to technical limitations. Following accessibility best practices, we want to clearly display this redirection to merchants, and want to remain consistent with the icon placement (on the right).
From a hierarchical standpoint, the primary and basic buttons are the most logical option in these instances.

Here are a couple example where external icons would be useful in buttons :

[alex-page]

Buttons going to external pages is an antipattern. I don't think we should scale this. Clicking a button should be a high trust moment.

In your situation what is happening? Is the page that the button takes the user to look and work the same as the admin? Does the user know they are going to a new website? Does the experience change dramatically?

Looking at the screenshots I believe these should be links and not buttons.

From the discussion #6558

[sarahill]

I agree with @alex-page 's comment above. In general we should make links look like links and buttons look like buttons. I know there are some edge cases but with the introduction of an external link icon inside a button, that really starts to bring link functionality into a button and I believe that will add confusion rather than clarity.

Some follow up questions / thoughts:

• Where are they going when they click the actions? Is it another SFN tool/product?
• If the links are taking them to a completely different site or app, I would suggest trying to convey that through the link text if possible

[github-actions]

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.